This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Lock mutex only for critical region in interop-level-zero-thread.cpp #1418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….cpp Signed-off-by: Rauf, Rana <[email protected]>
Signed-off-by: Rauf, Rana <[email protected]>
Signed-off-by: Rauf, Rana <[email protected]>
smaslov-intel
approved these changes
Nov 27, 2022
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
…ntel#1418) A number of tests currently use double and sycl::half despite them not being supported by the used device. Although it does not necessarily fail to run on those devices, they are not considered supported by the SYCL specification and should not be used in testing on those devices. This commit prevent parts of a selection of tests from running on devices that do not support the types used. Signed-off-by: Larsen, Steffen <[email protected]> Co-authored-by: Steffen Larsen <[email protected]>
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the test doesn't lock the mutex just in the critical region of code, effectively making the program almost single-threaded. Not a critical change but just an improvement