This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Re-enable select_device.cpp test #1488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)" This reverts commit cd0cf1c.
|
/verify with intel/llvm#7922 |
This was referenced Jan 5, 2023
smaslov-intel
approved these changes
Jan 6, 2023
sergey-semenov
approved these changes
Jan 12, 2023
|
The failing test on llvm-test-suite ( Basic/SubGroupMask.cpp ) is unrelated and was itself disabled, fixed, and renabled ( #1508) . The test in question ( Config/select_device.cpp ) is passing again and needs to be re-enabled. |
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
Revert "[SYCL] Temporarily disable Config/select_device.cpp (intel#1483)" This reverts commit cd0cf1c.
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
Revert "[SYCL] Temporarily disable Config/select_device.cpp (intel/llvm-test-suite#1483)" This reverts commit b19b0e7.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once the fix in intel/llvm#7923 is merged we should be able to re-enable the select_device.cpp test.
Revert "[SYCL] Temporarily disable Config/select_device.cpp (#1483)"
This reverts commit cd0cf1c.