This repository was archived by the owner on Mar 28, 2023. It is now read-only.
Disable USM pooling tests while implementation is being changed. #529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…undergoing changes. Signed-off-by: Rajiv Deodhar <[email protected]>
|
The two unexpected passes are expected. A change planned in the intel_llvm repo will cause those tests to fail. That's why they are marked ax XFAIL now, in anticipation of the intel_llvm change. |
sergey-semenov
previously approved these changes
Oct 22, 2021
jbrodman
previously approved these changes
Oct 25, 2021
rdeodhar
dismissed stale reviews from jbrodman and sergey-semenov
via
e028d84
vladimirlaz
approved these changes
Oct 28, 2021
vladimirlaz
suggested changes
Oct 28, 2021
vladimirlaz
previously approved these changes
Oct 29, 2021
|
Nothing has been changed, but need re-approval from code owners. |
sergey-semenov
previously approved these changes
Oct 29, 2021
jbrodman
previously approved these changes
Oct 29, 2021
againull
dismissed stale reviews from jbrodman, sergey-semenov, and vladimirlaz
via
e49aaf0
againull
approved these changes
Oct 29, 2021
jbrodman
approved these changes
Oct 29, 2021
|
Unrelated ESIMD tests failed, merging. |
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…el/llvm-test-suite#529) This change removes tests previously added for USM pooling. The pooling implementation is being changed. Once that change is completed these tests will be adjusted and reenabled.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes tests previously added for USM pooling. The pooling implementation is being changed. Once that change is completed these tests will be adjusted and reenabled.