Skip to content

Commit 007bcac

Browse files
committed
Addressed review comments.
Signed-off-by: Sergey Dmitriev <[email protected]>
1 parent e5c1afa commit 007bcac

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

.github/CODEOWNERS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,3 +91,4 @@ llvm/tools/sycl-post-link/ @kbobrovs @AlexeySachkov
9191

9292
clang/tools/clang-offload-bundler/ @kbobrovs @sndmitriev
9393
clang/tools/clang-offload-wrapper/ @sndmitriev @kbobrovs
94+
clang/tools/clang-offload-deps/ @sndmitriev

clang/tools/clang-offload-deps/ClangOffloadDeps.cpp

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -109,16 +109,15 @@ int main(int argc, const char **argv) {
109109
StringRef Kind;
110110
std::tie(Kind, Triples[I]) = StringRef(Targets[I]).split('-');
111111

112-
bool KindIsValid = !Kind.empty() && StringSwitch<bool>(Kind)
113-
.Case("host", true)
114-
.Case("openmp", true)
115-
.Case("hip", true)
116-
.Case("sycl", true)
117-
.Case("fpga", true)
118-
.Default(false);
119-
120-
bool TripleIsValid = !Triples[I].empty() &&
121-
Triple(Triples[I]).getArch() != Triple::UnknownArch;
112+
bool KindIsValid = StringSwitch<bool>(Kind)
113+
.Case("host", true)
114+
.Case("openmp", true)
115+
.Case("hip", true)
116+
.Case("sycl", true)
117+
.Case("fpga", true)
118+
.Default(false);
119+
120+
bool TripleIsValid = Triple(Triples[I]).getArch() != Triple::UnknownArch;
122121

123122
if (!KindIsValid || !TripleIsValid) {
124123
SmallVector<char, 128u> Buf;

0 commit comments

Comments
 (0)