Skip to content

Commit 0104ca5

Browse files
committed
Enable cmd-buf local memory update CTS tests on L0
The CTS tests for updating local memory in command-buffer kernel commands are currently skipped on Level-Zero. This feature is now available in L0 drivers so the tests can be enabled. There is a failure in `LocalMemoryUpdateTest.UpdateParametersSmallerLocalSize` with incorrect results. Mark the individual test as failed as it needs further investigation.
1 parent 3a1b4c7 commit 0104ca5

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

test/conformance/exp_command_buffer/update/local_memory_update.cpp

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,6 @@ struct LocalMemoryUpdateTestBase
1717
UUR_RETURN_ON_FATAL_FAILURE(
1818
urUpdatableCommandBufferExpExecutionTest::SetUp());
1919

20-
if (backend == UR_PLATFORM_BACKEND_LEVEL_ZERO) {
21-
GTEST_SKIP()
22-
<< "Local memory argument update not supported on Level Zero.";
23-
}
24-
2520
// HIP has extra args for local memory so we define an offset for arg
2621
// indices here for updating
2722
hip_arg_offset = backend == UR_PLATFORM_BACKEND_HIP ? 3 : 0;
@@ -391,6 +386,8 @@ TEST_P(LocalMemoryUpdateTest, UpdateParametersEmptyLocalSize) {
391386
// Test updating A,X,Y parameters to new values and local memory parameters
392387
// to new smaller values.
393388
TEST_P(LocalMemoryUpdateTest, UpdateParametersSmallerLocalSize) {
389+
UUR_KNOWN_FAILURE_ON(uur::LevelZero{});
390+
394391
// Run command-buffer prior to update an verify output
395392
ASSERT_SUCCESS(urCommandBufferEnqueueExp(updatable_cmd_buf_handle, queue, 0,
396393
nullptr, nullptr));
@@ -1310,4 +1307,4 @@ TEST_P(LocalMemoryUpdateTestOutOfOrder, UpdateAllParameters) {
13101307
uint32_t *new_X = (uint32_t *)shared_ptrs[3];
13111308
uint32_t *new_Y = (uint32_t *)shared_ptrs[4];
13121309
Validate(new_output, new_X, new_Y, new_A, global_size, local_size);
1313-
}
1310+
}

0 commit comments

Comments
 (0)