Address review comments

Signed-off-by: Soumi Manna <[email protected]>

Author: smanna12

clang/lib/Sema/SemaDeclAttr.cpp

@@ -3451,29 +3451,27 @@ static void handleWorkGroupSizeHint(Sema &S, Decl *D, const ParsedAttr &AL) {
 }
 
 // Handles max_work_group_size attribute.
-// Returns a AttrArgResult value; EqualToOne means all argument values are
-// equal to one, NotEqualToOne means at least one argument value is not
-// equal to one, and Unknown means that at least one of the argument values
-// could not be determined.
-enum class AttrArgResult { Unknown, EqualToOne, NotEqualToOne };
-static AttrArgResult AreAllAttrArgsOne(const Expr *E, const Expr *E1,
-                                       const Expr *E2, const Expr *E3) {
+// If the declaration has a SYCLIntelMaxWorkGroupSizeAttr,
+// check to see if the attribute holds equal values (1, 1, 1).
+// Returns true if the attribute values are equal to one.
+static bool InvalidWorkGroupSizeAttrs(const Expr *E, const Expr *E1,
+                                      const Expr *E2, const Expr *E3) {
   // If any of the operand is still value dependent, we can't test anything.
   const auto *CE = dyn_cast<ConstantExpr>(E);
   const auto *CE1 = dyn_cast<ConstantExpr>(E1);
   const auto *CE2 = dyn_cast<ConstantExpr>(E2);
   const auto *CE3 = dyn_cast<ConstantExpr>(E3);
 
   if (!CE || !CE1 || !CE2 || !CE3)
-    return AttrArgResult::Unknown;
+    return false;
 
   // Otherwise, check if the attribute values are equal to one.
   if (CE->getResultAsAPSInt() == 0 &&
       (CE1->getResultAsAPSInt() != 1 || CE2->getResultAsAPSInt() != 1 ||
        CE3->getResultAsAPSInt() != 1)) {
-    return AttrArgResult::NotEqualToOne;
+    return true;
   }
-  return AttrArgResult::EqualToOne;
+  return false;
 }
 
 void Sema::AddSYCLIntelMaxWorkGroupSizeAttr(Decl *D,
@@ -3520,8 +3518,7 @@ void Sema::AddSYCLIntelMaxWorkGroupSizeAttr(Decl *D,
   // the attribute holds equal values to (1, 1, 1) in case the value of
   // SYCLIntelMaxGlobalWorkDimAttr equals to 0.
   if (const auto *DeclAttr = D->getAttr<SYCLIntelMaxGlobalWorkDimAttr>()) {
-    if (AreAllAttrArgsOne(DeclAttr->getValue(), XDim, YDim, ZDim) ==
-        AttrArgResult::NotEqualToOne) {
+    if (InvalidWorkGroupSizeAttrs(DeclAttr->getValue(), XDim, YDim, ZDim)) {
       Diag(CI.getLoc(), diag::err_sycl_x_y_z_arguments_must_be_one)
           << CI << DeclAttr;
       return;
@@ -3582,8 +3579,8 @@ SYCLIntelMaxWorkGroupSizeAttr *Sema::MergeSYCLIntelMaxWorkGroupSizeAttr(
   // (1, 1, 1) in case the value of SYCLIntelMaxGlobalWorkDimAttr
   // equals to 0.
   if (const auto *DeclAttr = D->getAttr<SYCLIntelMaxGlobalWorkDimAttr>()) {
-    if (AreAllAttrArgsOne(DeclAttr->getValue(), A.getXDim(), A.getYDim(),
-                          A.getZDim()) == AttrArgResult::NotEqualToOne) {
+    if (InvalidWorkGroupSizeAttrs(DeclAttr->getValue(), A.getXDim(),
+			          A.getYDim(), A.getZDim())) {
       Diag(A.getLoc(), diag::err_sycl_x_y_z_arguments_must_be_one)
           << &A << DeclAttr;
       return nullptr;