Skip to content

Commit 0524da6

Browse files
author
Siva Chandra Reddy
committed
[libc][NFC] Use ASSERT_FP_EQ to comapre NaN values in tests.
1 parent eb66bf0 commit 0524da6

13 files changed

+13
-25
lines changed

libc/test/src/math/LdExpTest.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ class LdExpTestTemplate : public __llvm_libc::testing::Test {
4444
ASSERT_FP_EQ(negZero, func(negZero, exp));
4545
ASSERT_FP_EQ(inf, func(inf, exp));
4646
ASSERT_FP_EQ(negInf, func(negInf, exp));
47-
ASSERT_NE(isnan(func(nan, exp)), 0);
47+
ASSERT_FP_EQ(nan, func(nan, exp));
4848
}
4949
}
5050

libc/test/src/math/ceil_test.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,7 @@ TEST(CeilTest, SpecialNumbers) {
2626
EXPECT_FP_EQ(inf, __llvm_libc::ceil(inf));
2727
EXPECT_FP_EQ(negInf, __llvm_libc::ceil(negInf));
2828

29-
ASSERT_NE(isnan(aNaN), 0);
30-
ASSERT_NE(isnan(__llvm_libc::ceil(aNaN)), 0);
29+
EXPECT_FP_EQ(aNaN, __llvm_libc::ceil(aNaN));
3130
}
3231

3332
TEST(CeilTest, RoundedNumbers) {

libc/test/src/math/ceilf_test.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,7 @@ TEST(CeilfTest, SpecialNumbers) {
2626
EXPECT_FP_EQ(inf, __llvm_libc::ceilf(inf));
2727
EXPECT_FP_EQ(negInf, __llvm_libc::ceilf(negInf));
2828

29-
ASSERT_NE(isnan(aNaN), 0);
30-
ASSERT_NE(isnan(__llvm_libc::ceilf(aNaN)), 0);
29+
EXPECT_FP_EQ(aNaN, __llvm_libc::ceilf(aNaN));
3130
}
3231

3332
TEST(CeilfTest, RoundedNumbers) {

libc/test/src/math/ceill_test.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,7 @@ TEST(CeillTest, SpecialNumbers) {
2626
EXPECT_FP_EQ(inf, __llvm_libc::ceill(inf));
2727
EXPECT_FP_EQ(negInf, __llvm_libc::ceill(negInf));
2828

29-
ASSERT_NE(isnan(aNaN), 0);
30-
ASSERT_NE(isnan(__llvm_libc::ceill(aNaN)), 0);
29+
EXPECT_FP_EQ(aNaN, __llvm_libc::ceill(aNaN));
3130
}
3231

3332
TEST(CeillTest, RoundedNumbers) {

libc/test/src/math/floor_test.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,7 @@ TEST(FloorTest, SpecialNumbers) {
2626
EXPECT_FP_EQ(inf, __llvm_libc::floor(inf));
2727
EXPECT_FP_EQ(negInf, __llvm_libc::floor(negInf));
2828

29-
ASSERT_NE(isnan(aNaN), 0);
30-
ASSERT_NE(isnan(__llvm_libc::floor(aNaN)), 0);
29+
EXPECT_FP_EQ(aNaN, __llvm_libc::floor(aNaN));
3130
}
3231

3332
TEST(FloorTest, RoundedNumbers) {

libc/test/src/math/floorf_test.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,7 @@ TEST(FloorfTest, SpecialNumbers) {
2626
EXPECT_FP_EQ(inf, __llvm_libc::floorf(inf));
2727
EXPECT_FP_EQ(negInf, __llvm_libc::floorf(negInf));
2828

29-
ASSERT_NE(isnan(aNaN), 0);
30-
ASSERT_NE(isnan(__llvm_libc::floorf(aNaN)), 0);
29+
EXPECT_FP_EQ(aNaN, __llvm_libc::floorf(aNaN));
3130
}
3231

3332
TEST(FloorfTest, RoundedNumbers) {

libc/test/src/math/floorl_test.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,7 @@ TEST(FloorlTest, SpecialNumbers) {
2626
EXPECT_FP_EQ(inf, __llvm_libc::floorl(inf));
2727
EXPECT_FP_EQ(negInf, __llvm_libc::floorl(negInf));
2828

29-
ASSERT_NE(isnan(aNaN), 0);
30-
ASSERT_NE(isnan(__llvm_libc::floorl(aNaN)), 0);
29+
EXPECT_FP_EQ(aNaN, __llvm_libc::floorl(aNaN));
3130
}
3231

3332
TEST(FloorlTest, RoundedNumbers) {

libc/test/src/math/round_test.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,7 @@ TEST(RoundTest, SpecialNumbers) {
2626
EXPECT_FP_EQ(inf, __llvm_libc::round(inf));
2727
EXPECT_FP_EQ(negInf, __llvm_libc::round(negInf));
2828

29-
ASSERT_NE(isnan(aNaN), 0);
30-
ASSERT_NE(isnan(__llvm_libc::round(aNaN)), 0);
29+
EXPECT_FP_EQ(aNaN, __llvm_libc::round(aNaN));
3130
}
3231

3332
TEST(RoundTest, RoundedNumbers) {

libc/test/src/math/roundf_test.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,7 @@ TEST(RoundfTest, SpecialNumbers) {
2626
EXPECT_FP_EQ(inf, __llvm_libc::roundf(inf));
2727
EXPECT_FP_EQ(negInf, __llvm_libc::roundf(negInf));
2828

29-
ASSERT_NE(isnan(aNaN), 0);
30-
ASSERT_NE(isnan(__llvm_libc::roundf(aNaN)), 0);
29+
EXPECT_FP_EQ(aNaN, __llvm_libc::roundf(aNaN));
3130
}
3231

3332
TEST(RoundfTest, RoundedNumbers) {

libc/test/src/math/roundl_test.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,7 @@ TEST(RoundlTest, SpecialNumbers) {
2626
EXPECT_FP_EQ(inf, __llvm_libc::roundl(inf));
2727
EXPECT_FP_EQ(negInf, __llvm_libc::roundl(negInf));
2828

29-
ASSERT_NE(isnan(aNaN), 0);
30-
ASSERT_NE(isnan(__llvm_libc::roundl(aNaN)), 0);
29+
EXPECT_FP_EQ(aNaN, __llvm_libc::roundl(aNaN));
3130
}
3231

3332
TEST(RoundlTest, RoundedNumbers) {

libc/test/src/math/trunc_test.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,7 @@ TEST(TruncTest, SpecialNumbers) {
2626
EXPECT_FP_EQ(inf, __llvm_libc::trunc(inf));
2727
EXPECT_FP_EQ(negInf, __llvm_libc::trunc(negInf));
2828

29-
ASSERT_NE(isnan(aNaN), 0);
30-
ASSERT_NE(isnan(__llvm_libc::trunc(aNaN)), 0);
29+
EXPECT_FP_EQ(aNaN, __llvm_libc::trunc(aNaN));
3130
}
3231

3332
TEST(TruncTest, RoundedNumbers) {

libc/test/src/math/truncf_test.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,7 @@ TEST(TruncfTest, SpecialNumbers) {
2626
EXPECT_FP_EQ(inf, __llvm_libc::truncf(inf));
2727
EXPECT_FP_EQ(negInf, __llvm_libc::truncf(negInf));
2828

29-
ASSERT_NE(isnan(aNaN), 0);
30-
ASSERT_NE(isnan(__llvm_libc::truncf(aNaN)), 0);
29+
EXPECT_FP_EQ(aNaN, __llvm_libc::truncf(aNaN));
3130
}
3231

3332
TEST(TruncfTest, RoundedNumbers) {

libc/test/src/math/truncl_test.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,7 @@ TEST(TrunclTest, SpecialNumbers) {
2626
EXPECT_FP_EQ(inf, __llvm_libc::truncl(inf));
2727
EXPECT_FP_EQ(negInf, __llvm_libc::truncl(negInf));
2828

29-
ASSERT_NE(isnan(aNaN), 0);
30-
ASSERT_NE(isnan(__llvm_libc::truncl(aNaN)), 0);
29+
EXPECT_FP_EQ(aNaN, __llvm_libc::truncl(aNaN));
3130
}
3231

3332
TEST(TrunclTest, RoundedNumbers) {

0 commit comments

Comments
 (0)