Skip to content

Commit 05a3db7

Browse files
EwanCmartygrant
authored andcommitted
Fix how unsupported tests are marked
1 parent f8abcec commit 05a3db7

21 files changed

+24
-28
lines changed

sycl/test-e2e/Graph/Explicit/cycle_error.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ void CreateGraphWithCyclesTest(bool DisableCycleChecks) {
1717
queue Queue;
1818

1919
if (!are_graphs_supported(Queue)) {
20-
return 0;
20+
return;
2121
}
2222

2323
property_list Props;

sycl/test-e2e/Graph/Explicit/debug_print_graph.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
// RUN: %{build} -o %t.out
2-
// RUN: %if linux %{ %{run} %t.out ; FileCheck %s --input-file graph.dot %}
3-
// RUN: %if windows %{ %{run} %t.out %}
2+
// RUN: %if linux && (ext_oneapi_level_zero || ext_oneapi_cuda) %{ %{run} %t.out ; FileCheck %s --input-file graph.dot %} %else %{ %{run} %t.out %}
43
// Windows output format differs from linux format.
54
// The filecheck-based output checking is suited to linux standards.
65
// On Windows, we only test that printing takes place correctly and does not
7-
// trigger errors or throw execeptions.
6+
// trigger errors or throw exceptions.
87
//
98
// CHECK: digraph dot {
109
// CHECK-NEXT: "0x[[#%x,NODE1:]]"

sycl/test-e2e/Graph/Explicit/debug_print_graph_verbose.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
// RUN: %{build} -o %t.out
2-
// RUN: %if linux %{ %{run} %t.out ; FileCheck %s --input-file graph_verbose.dot %}
3-
// RUN: %if windows %{ %{run} %t.out %}
2+
// RUN: %if linux && (ext_oneapi_level_zero || ext_oneapi_cuda) %{ %{run} %t.out ; FileCheck %s --input-file graph.dot %} %else %{ %{run} %t.out %}
43
// Windows output format differs from linux format.
54
// The filecheck-based output checking is suited to linux standards.
65
// On Windows, we only test that printing takes place correctly and does not

sycl/test-e2e/Graph/Explicit/dotp_buffer_reduction.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
// CHECK-NOT: LEAK
77

88
// Expected fail as reduction support is not complete.
9-
// UNSUPPORTED: *
9+
// REQUIRES: NOT_YET_IMPLEMENTED
1010

1111
#define GRAPH_E2E_EXPLICIT
1212

sycl/test-e2e/Graph/Explicit/dotp_usm_reduction.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
// CHECK-NOT: LEAK
77

88
// Expected fail as reduction support is not complete.
9-
// UNSUPPORTED: *
9+
// REQUIRES: NOT_YET_IMPLEMENTED
1010

1111
#define GRAPH_E2E_EXPLICIT
1212

sycl/test-e2e/Graph/Explicit/double_buffer.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
// CHECK-NOT: LEAK
77

88
// Expected fail as executable graph update isn't implemented yet
9-
// UNSUPPORTED: *
9+
// REQUIRES: NOT_YET_IMPLEMENTED
1010

1111
#define GRAPH_E2E_EXPLICIT
1212

sycl/test-e2e/Graph/Explicit/event_status_querying.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// RUN: %{build} -o %t.out
2-
// RUN: %{run} %t.out 2>&1 | FileCheck %s
2+
// RUN: %if ext_oneapi_level_zero || ext_oneapi_cuda %{ %{run} %t.out 2>&1 | FileCheck %s %} %else %{ %{run} %t.out %}
33
//
44
// CHECK: complete
55
//

sycl/test-e2e/Graph/Explicit/executable_graph_update.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
// CHECK-NOT: LEAK
77

88
// Expected fail as executable graph update not implemented yet
9-
// UNSUPPORTED: *
9+
// REQUIRES: NOT_YET_IMPLEMENTED
1010

1111
#define GRAPH_E2E_EXPLICIT
1212

sycl/test-e2e/Graph/Explicit/stream.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
// CHECK-NOT: LEAK
66

77
// Expected fail as sycl streams aren't implemented yet
8-
// UNSUPPORTED: *
8+
// REQUIRES: NOT_YET_IMPLEMENTED
99

1010
#define GRAPH_E2E_EXPLICIT
1111

sycl/test-e2e/Graph/Explicit/sub_graph_reduction.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
// CHECK-NOT: LEAK
77

88
// Expected fail as reduction support is not complete.
9-
// UNSUPPORTED: *
9+
// REQUIRES: NOT_YET_IMPLEMENTED
1010

1111
#define GRAPH_E2E_EXPLICIT
1212

sycl/test-e2e/Graph/RecordReplay/debug_print_graph.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
// RUN: %{build} -o %t.out
2-
// RUN: %if linux %{ %{run} %t.out ; FileCheck %s --input-file graph.dot %}
3-
// RUN: %if windows %{ %{run} %t.out %}
2+
// RUN: %if linux && (ext_oneapi_level_zero || ext_oneapi_cuda) %{ %{run} %t.out ; FileCheck %s --input-file graph.dot %} %else %{ %{run} %t.out %}
43
// Windows output format differs from linux format.
54
// The filecheck-based output checking is suited to linux standards.
65
// On Windows, we only test that printing takes place correctly and does not
7-
// trigger errors or throw execeptions.
6+
// trigger errors or throw exceptions.
87
//
98
// CHECK: digraph dot {
109
// CHECK-NEXT: "0x[[#%x,NODE1:]]"

sycl/test-e2e/Graph/RecordReplay/debug_print_graph_verbose.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
// RUN: %{build} -o %t.out
2-
// RUN: %if linux %{ %{run} %t.out ; FileCheck %s --input-file graph_verbose.dot %}
3-
// RUN: %if windows %{ %{run} %t.out %}
2+
// RUN: %if linux && (ext_oneapi_level_zero || ext_oneapi_cuda) %{ %{run} %t.out ; FileCheck %s --input-file graph.dot %} %else %{ %{run} %t.out %}
43
// Windows output format differs from linux format.
54
// The filecheck-based output checking is suited to linux standards.
65
// On Windows, we only test that printing takes place correctly and does not
7-
// trigger errors or throw execeptions.
6+
// trigger errors or throw exceptions.
87
//
98
//
109
// CHECK: digraph dot {

sycl/test-e2e/Graph/RecordReplay/dotp_buffer_reduction.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
// CHECK-NOT: LEAK
77

88
// Expected fail as reduction support is not complete.
9-
// UNSUPPORTED: *
9+
// REQUIRES: NOT_YET_IMPLEMENTED
1010

1111
#define GRAPH_E2E_RECORD_REPLAY
1212

sycl/test-e2e/Graph/RecordReplay/dotp_usm_reduction.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
// CHECK-NOT: LEAK
77

88
// Expected fail as reduction support is not complete.
9-
// UNSUPPORTED: *
9+
// REQUIRES: NOT_YET_IMPLEMENTED
1010

1111
#define GRAPH_E2E_RECORD_REPLAY
1212

sycl/test-e2e/Graph/RecordReplay/double_buffer.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
// CHECK-NOT: LEAK
77

88
// Expected fail as executable graph update not yet implemented
9-
// UNSUPPORTED: *
9+
// REQUIRES: NOT_YET_IMPLEMENTED
1010

1111
#define GRAPH_E2E_RECORD_REPLAY
1212

sycl/test-e2e/Graph/RecordReplay/event_status_querying.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// RUN: %{build} -o %t.out
2-
// RUN: %{run} %t.out 2>&1 | FileCheck %s
2+
// RUN: %if ext_oneapi_level_zero || ext_oneapi_cuda %{ %{run} %t.out 2>&1 | FileCheck %s %} %else %{ %{run} %t.out %}
33
//
44
// CHECK: complete
55
//

sycl/test-e2e/Graph/RecordReplay/executable_graph_update.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
// CHECK-NOT: LEAK
77

88
// Expected fail as executable graph update not implemented yet
9-
// UNSUPPORTED: *
9+
// REQUIRES: NOT_YET_IMPLEMENTED
1010

1111
#define GRAPH_E2E_RECORD_REPLAY
1212

sycl/test-e2e/Graph/RecordReplay/stream.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
// CHECK-NOT: LEAK
66

77
// Expected fail as sycl::stream is not implemented yet
8-
// UNSUPPORTED: *
8+
// REQUIRES: NOT_YET_IMPLEMENTED
99

1010
#define GRAPH_E2E_RECORD_REPLAY
1111

sycl/test-e2e/Graph/RecordReplay/sub_graph_reduction.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
// CHECK-NOT: LEAK
77

88
// Expected fail as reduction support is not complete.
9-
// UNSUPPORTED: *
9+
// REQUIRES: NOT_YET_IMPLEMENTED
1010

1111
#define GRAPH_E2E_RECORD_REPLAY
1212

sycl/test-e2e/Graph/RecordReplay/temp_buffer.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
// CHECK-NOT: LEAK
77

88
// Fail that needs investigation
9-
// UNSUPPORTED: *
9+
// REQUIRES: NOT_YET_IMPLEMENTED
1010

1111
// This test creates a temporary buffer which is used in kernels, but
1212
// destroyed before finalization and execution of the graph.

sycl/test-e2e/Graph/graph_exception_global_device_extension.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ template <OperationPath PathKind, typename T> void test(queue Queue) {
2222
exp_ext::command_graph Graph{Queue.get_context(), Queue.get_device()};
2323

2424
if constexpr (PathKind != OperationPath::Explicit) {
25-
Graph.begin_recording(Q);
25+
Graph.begin_recording(Queue);
2626
}
2727

2828
// Copy from device globals before having written anything.

0 commit comments

Comments
 (0)