Skip to content

Commit 09dea92

Browse files
svenvhsys-ce-bb
authored andcommitted
Fix image access in link-attribute test (#2598)
The test performed a read_image operation on an image declared `write_only`. `spirv-val` recently started flagging this. Update the image access attribute to "read-only" (i.e., 0). Fixes KhronosGroup/SPIRV-LLVM-Translator#2597 Original commit: KhronosGroup/SPIRV-LLVM-Translator@bd0fffe337d27b3
1 parent f1e0207 commit 09dea92

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

llvm-spirv/test/link-attribute.ll

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,19 +13,19 @@ target triple = "spir64-unknown-unknown"
1313
@imageSampler = addrspace(2) constant i32 36, align 4
1414

1515
; Function Attrs: nounwind
16-
define spir_kernel void @sample_kernel(target("spirv.Image", void, 1, 0, 0, 0, 0, 0, 1) %input, ptr addrspace(1) nocapture %xOffsets, ptr addrspace(1) nocapture %yOffsets, ptr addrspace(1) nocapture %results) #0 !kernel_arg_addr_space !1 !kernel_arg_access_qual !2 !kernel_arg_type !3 !kernel_arg_base_type !5 !kernel_arg_type_qual !4 {
16+
define spir_kernel void @sample_kernel(target("spirv.Image", void, 1, 0, 0, 0, 0, 0, 0) %input, ptr addrspace(1) nocapture %xOffsets, ptr addrspace(1) nocapture %yOffsets, ptr addrspace(1) nocapture %results) #0 !kernel_arg_addr_space !1 !kernel_arg_access_qual !2 !kernel_arg_type !3 !kernel_arg_base_type !5 !kernel_arg_type_qual !4 {
1717
%1 = tail call spir_func i64 @_Z13get_global_idj(i32 0) #1
1818
%2 = trunc i64 %1 to i32
1919
%3 = tail call spir_func i64 @_Z13get_global_idj(i32 1) #1
2020
%4 = trunc i64 %3 to i32
21-
%5 = tail call spir_func i32 @_Z15get_image_width11ocl_image2d(target("spirv.Image", void, 1, 0, 0, 0, 0, 0, 1) %input) #1
21+
%5 = tail call spir_func i32 @_Z15get_image_width11ocl_image2d(target("spirv.Image", void, 1, 0, 0, 0, 0, 0, 0) %input) #1
2222
%6 = mul nsw i32 %4, %5
2323
%7 = add nsw i32 %6, %2
2424
%8 = sitofp i32 %2 to float
2525
%9 = insertelement <2 x float> undef, float %8, i32 0
2626
%10 = sitofp i32 %4 to float
2727
%11 = insertelement <2 x float> %9, float %10, i32 1
28-
%12 = tail call spir_func <4 x float> @_Z11read_imagef11ocl_image2d11ocl_samplerDv2_f(target("spirv.Image", void, 1, 0, 0, 0, 0, 0, 1) %input, i32 36, <2 x float> %11) #1
28+
%12 = tail call spir_func <4 x float> @_Z11read_imagef11ocl_image2d11ocl_samplerDv2_f(target("spirv.Image", void, 1, 0, 0, 0, 0, 0, 0) %input, i32 36, <2 x float> %11) #1
2929
%13 = sext i32 %7 to i64
3030
%14 = getelementptr inbounds <4 x float>, ptr addrspace(1) %results, i64 %13
3131
store <4 x float> %12, ptr addrspace(1) %14, align 16, !tbaa !11
@@ -36,10 +36,10 @@ define spir_kernel void @sample_kernel(target("spirv.Image", void, 1, 0, 0, 0, 0
3636
declare spir_func i64 @_Z13get_global_idj(i32) #1
3737

3838
; Function Attrs: nounwind readnone
39-
declare spir_func i32 @_Z15get_image_width11ocl_image2d(target("spirv.Image", void, 1, 0, 0, 0, 0, 0, 1)) #1
39+
declare spir_func i32 @_Z15get_image_width11ocl_image2d(target("spirv.Image", void, 1, 0, 0, 0, 0, 0, 0)) #1
4040

4141
; Function Attrs: nounwind readnone
42-
declare spir_func <4 x float> @_Z11read_imagef11ocl_image2d11ocl_samplerDv2_f(target("spirv.Image", void, 1, 0, 0, 0, 0, 0, 1), i32, <2 x float>) #1
42+
declare spir_func <4 x float> @_Z11read_imagef11ocl_image2d11ocl_samplerDv2_f(target("spirv.Image", void, 1, 0, 0, 0, 0, 0, 0), i32, <2 x float>) #1
4343

4444
attributes #0 = { nounwind }
4545
attributes #1 = { nounwind readnone }

0 commit comments

Comments
 (0)