Skip to content

Commit 0b9c1e7

Browse files
Removing 'TODO' comments for tests from intel/llvm-test-suite
- As esimd_emulator is only for ESIMD kernels, PI_APIs causing failures for non-ESIMD kernels are not going to be implemented. 'TODO' comments are removed for such PI_APIs - CMakeLists change : installtion path fix for headers imported from CM
1 parent 8ba735d commit 0b9c1e7

File tree

2 files changed

+2
-10
lines changed

2 files changed

+2
-10
lines changed

sycl/plugins/esimd_emulator/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ install(TARGETS pi_esimd_emulator
138138

139139
# Copy CM Header files to $(INSTALL)/include/sycl/CL/
140140
install(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/cm-emu_install/include/libcm/cm/
141-
DESTINATION ${SYCL_INCLUDE_DIR}/CL
141+
DESTINATION ${SYCL_INCLUDE_DIR}/sycl/CL
142142
COMPONENT libcmrt-headers
143143
FILES_MATCHING PATTERN "*.h"
144144
)

sycl/plugins/esimd_emulator/pi_esimd_emulator.cpp

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1360,7 +1360,6 @@ pi_result piEnqueueMemBufferReadRect(pi_queue, pi_mem, pi_bool,
13601360
pi_result piEnqueueMemBufferWrite(pi_queue, pi_mem, pi_bool, size_t, size_t,
13611361
const void *, pi_uint32, const pi_event *,
13621362
pi_event *) {
1363-
// TODO : intel/llvm_test_suite
13641363
DIE_NO_IMPLEMENTATION;
13651364
}
13661365

@@ -1375,7 +1374,6 @@ pi_result piEnqueueMemBufferWriteRect(pi_queue, pi_mem, pi_bool,
13751374
pi_result piEnqueueMemBufferCopy(pi_queue, pi_mem, pi_mem, size_t, size_t,
13761375
size_t, pi_uint32, const pi_event *,
13771376
pi_event *) {
1378-
// TODO : intel/llvm_test_suite
13791377
DIE_NO_IMPLEMENTATION;
13801378
}
13811379

@@ -1384,21 +1382,18 @@ pi_result piEnqueueMemBufferCopyRect(pi_queue, pi_mem, pi_mem,
13841382
pi_buff_rect_region, size_t, size_t,
13851383
size_t, size_t, pi_uint32,
13861384
const pi_event *, pi_event *) {
1387-
// TODO : intel/llvm_test_suite
13881385
DIE_NO_IMPLEMENTATION;
13891386
}
13901387

13911388
pi_result piEnqueueMemBufferFill(pi_queue, pi_mem, const void *, size_t, size_t,
13921389
size_t, pi_uint32, const pi_event *,
13931390
pi_event *) {
1394-
// TODO : intel/llvm_test_suite
13951391
DIE_NO_IMPLEMENTATION;
13961392
}
13971393

13981394
pi_result piEnqueueMemBufferMap(pi_queue, pi_mem, pi_bool, pi_map_flags, size_t,
13991395
size_t, pi_uint32, const pi_event *, pi_event *,
14001396
void **) {
1401-
// TODO : intel/llvm_test_suite
14021397
DIE_NO_IMPLEMENTATION;
14031398
}
14041399

@@ -1625,7 +1620,6 @@ pi_result piextKernelSetArgPointer(pi_kernel, pi_uint32, size_t, const void *) {
16251620

16261621
pi_result piextUSMEnqueueMemset(pi_queue, void *, pi_int32, size_t, pi_uint32,
16271622
const pi_event *, pi_event *) {
1628-
// TODO : intel/llvm_test_suite
16291623
DIE_NO_IMPLEMENTATION;
16301624
}
16311625

@@ -1636,7 +1630,6 @@ pi_result piextUSMEnqueueMemcpy(pi_queue, pi_bool, void *, const void *, size_t,
16361630

16371631
pi_result piextUSMEnqueueMemAdvise(pi_queue, const void *, size_t,
16381632
pi_mem_advice, pi_event *) {
1639-
// TODO : intel/llvm_test_suite
16401633
DIE_NO_IMPLEMENTATION;
16411634
}
16421635

@@ -1674,8 +1667,7 @@ pi_result piextDeviceSelectBinary(pi_device, pi_device_binary *,
16741667
pi_result piextUSMEnqueuePrefetch(pi_queue, const void *, size_t,
16751668
pi_usm_migration_flags, pi_uint32,
16761669
const pi_event *, pi_event *) {
1677-
// NOP for prefetch
1678-
return PI_SUCCESS;
1670+
DIE_NO_IMPLEMENTATION;
16791671
}
16801672

16811673
pi_result piextPluginGetOpaqueData(void *, void **OpaqueDataReturn) {

0 commit comments

Comments
 (0)