Skip to content

Commit 0c4c22c

Browse files
committed
Addressed to review comments
1 parent 1cfb090 commit 0c4c22c

File tree

1 file changed

+28
-18
lines changed

1 file changed

+28
-18
lines changed

sycl/include/CL/sycl/known_identity.hpp

Lines changed: 28 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -21,42 +21,52 @@ using cl::sycl::detail::is_sgeninteger;
2121

2222
template <typename T, class BinaryOperation>
2323
using IsReduPlus =
24-
bool_constant<std::is_same<BinaryOperation, std::plus<T>>::value ||
25-
std::is_same<BinaryOperation, std::plus<void>>::value>;
24+
bool_constant<std::is_same<BinaryOperation, sycl::plus<T>>::value ||
25+
std::is_same<BinaryOperation, sycl::plus<void>>::value ||
26+
std::is_same<BinaryOperation, ONEAPI::plus<T>>::value ||
27+
std::is_same<BinaryOperation, ONEAPI::plus<void>>::value>;
2628

2729
template <typename T, class BinaryOperation>
2830
using IsReduMultiplies =
29-
bool_constant<std::is_same<BinaryOperation, std::multiplies<T>>::value ||
30-
std::is_same<BinaryOperation, std::multiplies<void>>::value>;
31+
bool_constant<std::is_same<BinaryOperation, sycl::multiplies<T>>::value ||
32+
std::is_same<BinaryOperation, sycl::multiplies<void>>::value ||
33+
std::is_same<BinaryOperation, ONEAPI::multiplies<T>>::value ||
34+
std::is_same<BinaryOperation, ONEAPI::multiplies<void>>::value>;
3135

3236
template <typename T, class BinaryOperation>
3337
using IsReduMinimum =
34-
bool_constant<std::is_same<BinaryOperation, ONEAPI::minimum<T>>::value ||
35-
std::is_same<BinaryOperation, ONEAPI::minimum<void>>::value ||
36-
std::is_same<BinaryOperation, sycl::minimum<T>>::value ||
37-
std::is_same<BinaryOperation, sycl::minimum<void>>::value>;
38+
bool_constant<std::is_same<BinaryOperation, sycl::minimum<T>>::value ||
39+
std::is_same<BinaryOperation, sycl::minimum<void>>::value ||
40+
std::is_same<BinaryOperation, ONEAPI::minimum<T>>::value ||
41+
std::is_same<BinaryOperation, ONEAPI::minimum<void>>::value>;
3842

3943
template <typename T, class BinaryOperation>
4044
using IsReduMaximum =
41-
bool_constant<std::is_same<BinaryOperation, ONEAPI::maximum<T>>::value ||
42-
std::is_same<BinaryOperation, ONEAPI::maximum<void>>::value ||
43-
std::is_same<BinaryOperation, sycl::maximum<T>>::value ||
44-
std::is_same<BinaryOperation, sycl::maximum<void>>::value>;
45+
bool_constant<std::is_same<BinaryOperation, sycl::maximum<T>>::value ||
46+
std::is_same<BinaryOperation, sycl::maximum<void>>::value ||
47+
std::is_same<BinaryOperation, ONEAPI::maximum<T>>::value ||
48+
std::is_same<BinaryOperation, ONEAPI::maximum<void>>::value>;
4549

4650
template <typename T, class BinaryOperation>
4751
using IsReduBitOR =
48-
bool_constant<std::is_same<BinaryOperation, std::bit_or<T>>::value ||
49-
std::is_same<BinaryOperation, std::bit_or<void>>::value>;
52+
bool_constant<std::is_same<BinaryOperation, sycl::bit_or<T>>::value ||
53+
std::is_same<BinaryOperation, sycl::bit_or<void>>::value ||
54+
std::is_same<BinaryOperation, ONEAPI::bit_or<T>>::value ||
55+
std::is_same<BinaryOperation, ONEAPI::bit_or<void>>::value>;
5056

5157
template <typename T, class BinaryOperation>
5258
using IsReduBitXOR =
53-
bool_constant<std::is_same<BinaryOperation, std::bit_xor<T>>::value ||
54-
std::is_same<BinaryOperation, std::bit_xor<void>>::value>;
59+
bool_constant<std::is_same<BinaryOperation, sycl::bit_xor<T>>::value ||
60+
std::is_same<BinaryOperation, sycl::bit_xor<void>>::value ||
61+
std::is_same<BinaryOperation, ONEAPI::bit_xor<T>>::value ||
62+
std::is_same<BinaryOperation, ONEAPI::bit_xor<void>>::value>;
5563

5664
template <typename T, class BinaryOperation>
5765
using IsReduBitAND =
58-
bool_constant<std::is_same<BinaryOperation, std::bit_and<T>>::value ||
59-
std::is_same<BinaryOperation, std::bit_and<void>>::value>;
66+
bool_constant<std::is_same<BinaryOperation, sycl::bit_and<T>>::value ||
67+
std::is_same<BinaryOperation, sycl::bit_and<void>>::value ||
68+
std::is_same<BinaryOperation, ONEAPI::bit_and<T>>::value ||
69+
std::is_same<BinaryOperation, ONEAPI::bit_and<void>>::value>;
6070

6171
template <typename T, class BinaryOperation>
6272
using IsReduOptForFastAtomicFetch =

0 commit comments

Comments
 (0)