Skip to content

Commit 0e22d6f

Browse files
callumfarecallumfare
committed
[SYCL][UR][CUDA] Remove unnecessary input validation from UR entry points
These checks are already performed by the UR validation layer
1 parent 21ca00f commit 0e22d6f

File tree

11 files changed

+14
-229
lines changed

11 files changed

+14
-229
lines changed

‎sycl/plugins/unified_runtime/ur/adapters/cuda/context.cpp

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,6 @@ urContextCreate(uint32_t DeviceCount, const ur_device_handle_t *phDevices,
2424
ur_context_handle_t *phContext) {
2525
std::ignore = DeviceCount;
2626
std::ignore = pProperties;
27-
UR_ASSERT(phDevices, UR_RESULT_ERROR_INVALID_NULL_POINTER);
28-
UR_ASSERT(phContext, UR_RESULT_ERROR_INVALID_NULL_POINTER);
2927

3028
assert(DeviceCount == 1);
3129
ur_result_t RetErr = UR_RESULT_SUCCESS;
@@ -46,8 +44,6 @@ urContextCreate(uint32_t DeviceCount, const ur_device_handle_t *phDevices,
4644
UR_APIEXPORT ur_result_t UR_APICALL urContextGetInfo(
4745
ur_context_handle_t hContext, ur_context_info_t ContextInfoType,
4846
size_t propSize, void *pContextInfo, size_t *pPropSizeRet) {
49-
UR_ASSERT(hContext, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
50-
5147
UrReturnHelper ReturnValue(propSize, pContextInfo, pPropSizeRet);
5248

5349
switch (uint32_t{ContextInfoType}) {
@@ -98,8 +94,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urContextGetInfo(
9894

9995
UR_APIEXPORT ur_result_t UR_APICALL
10096
urContextRelease(ur_context_handle_t hContext) {
101-
UR_ASSERT(hContext, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
102-
10397
if (hContext->decrementReferenceCount() > 0) {
10498
return UR_RESULT_SUCCESS;
10599
}
@@ -112,8 +106,6 @@ urContextRelease(ur_context_handle_t hContext) {
112106

113107
UR_APIEXPORT ur_result_t UR_APICALL
114108
urContextRetain(ur_context_handle_t hContext) {
115-
UR_ASSERT(hContext, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
116-
117109
assert(hContext->getReferenceCount() > 0);
118110

119111
hContext->incrementReferenceCount();
@@ -122,9 +114,6 @@ urContextRetain(ur_context_handle_t hContext) {
122114

123115
UR_APIEXPORT ur_result_t UR_APICALL urContextGetNativeHandle(
124116
ur_context_handle_t hContext, ur_native_handle_t *phNativeContext) {
125-
UR_ASSERT(hContext, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
126-
UR_ASSERT(phNativeContext, UR_RESULT_ERROR_INVALID_NULL_POINTER);
127-
128117
*phNativeContext = reinterpret_cast<ur_native_handle_t>(hContext->get());
129118
return UR_RESULT_SUCCESS;
130119
}
@@ -146,9 +135,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urContextCreateWithNativeHandle(
146135
UR_APIEXPORT ur_result_t UR_APICALL urContextSetExtendedDeleter(
147136
ur_context_handle_t hContext, ur_context_extended_deleter_t pfnDeleter,
148137
void *pUserData) {
149-
UR_ASSERT(hContext, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
150-
UR_ASSERT(pfnDeleter, UR_RESULT_ERROR_INVALID_NULL_POINTER);
151-
152138
hContext->setExtendedDeleter(pfnDeleter, pUserData);
153139
return UR_RESULT_SUCCESS;
154140
}

‎sycl/plugins/unified_runtime/ur/adapters/cuda/device.cpp

Lines changed: 3 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(ur_device_handle_t hDevice,
3737
size_t propSize,
3838
void *pPropValue,
3939
size_t *pPropSizeRet) {
40-
UR_ASSERT(hDevice, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
4140
UrReturnHelper ReturnValue(propSize, pPropValue, pPropSizeRet);
4241

4342
static constexpr uint32_t MaxWorkItemDimensions = 3u;
@@ -1017,8 +1016,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(ur_device_handle_t hDevice,
10171016
/// \return PI_SUCCESS if the function is executed successfully
10181017
/// CUDA devices are always root devices so retain always returns success.
10191018
UR_APIEXPORT ur_result_t UR_APICALL urDeviceRetain(ur_device_handle_t hDevice) {
1020-
UR_ASSERT(hDevice, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
1021-
1019+
std::ignore = hDevice;
10221020
return UR_RESULT_SUCCESS;
10231021
}
10241022

@@ -1032,8 +1030,7 @@ urDevicePartition(ur_device_handle_t, const ur_device_partition_properties_t *,
10321030
/// devices.
10331031
UR_APIEXPORT ur_result_t UR_APICALL
10341032
urDeviceRelease(ur_device_handle_t hDevice) {
1035-
UR_ASSERT(hDevice, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
1036-
1033+
std::ignore = hDevice;
10371034
return UR_RESULT_SUCCESS;
10381035
}
10391036

@@ -1048,13 +1045,9 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGet(ur_platform_handle_t hPlatform,
10481045
const bool AskingForGPU = DeviceType == UR_DEVICE_TYPE_GPU;
10491046
const bool ReturnDevices = AskingForDefault || AskingForAll || AskingForGPU;
10501047

1051-
UR_ASSERT(hPlatform, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
1052-
10531048
size_t NumDevices = ReturnDevices ? hPlatform->Devices.size() : 0;
10541049

10551050
try {
1056-
UR_ASSERT(pNumDevices || phDevices, UR_RESULT_ERROR_INVALID_VALUE);
1057-
10581051
if (pNumDevices) {
10591052
*pNumDevices = NumDevices;
10601053
}
@@ -1082,9 +1075,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGet(ur_platform_handle_t hPlatform,
10821075

10831076
UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetNativeHandle(
10841077
ur_device_handle_t hDevice, ur_native_handle_t *phNativeHandle) {
1085-
UR_ASSERT(hDevice, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
1086-
UR_ASSERT(phNativeHandle, UR_RESULT_ERROR_INVALID_NULL_POINTER);
1087-
10881078
*phNativeHandle = reinterpret_cast<ur_native_handle_t>(hDevice->get());
10891079
return UR_RESULT_SUCCESS;
10901080
}
@@ -1103,7 +1093,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceCreateWithNativeHandle(
11031093
const ur_device_native_properties_t *pProperties,
11041094
ur_device_handle_t *phDevice) {
11051095
std::ignore = pProperties;
1106-
UR_ASSERT(phDevice, UR_RESULT_ERROR_INVALID_NULL_POINTER);
11071096

11081097
// We can't cast between ur_native_handle_t and CUdevice, so memcpy the bits
11091098
// instead
@@ -1154,8 +1143,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceCreateWithNativeHandle(
11541143
ur_result_t UR_APICALL urDeviceGetGlobalTimestamps(ur_device_handle_t hDevice,
11551144
uint64_t *pDeviceTimestamp,
11561145
uint64_t *pHostTimestamp) {
1157-
UR_ASSERT(hDevice, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
1158-
11591146
CUevent Event;
11601147
ScopedContext Active(hDevice->getContext());
11611148

@@ -1184,11 +1171,7 @@ ur_result_t UR_APICALL urDeviceGetGlobalTimestamps(ur_device_handle_t hDevice,
11841171
UR_APIEXPORT ur_result_t UR_APICALL urDeviceSelectBinary(
11851172
ur_device_handle_t hDevice, const ur_device_binary_t *pBinaries,
11861173
uint32_t NumBinaries, uint32_t *pSelectedBinary) {
1187-
// Ignore unused parameter
1188-
(void)hDevice;
1189-
1190-
UR_ASSERT(pBinaries, UR_RESULT_ERROR_INVALID_NULL_POINTER);
1191-
UR_ASSERT(NumBinaries > 0, UR_RESULT_ERROR_INVALID_ARGUMENT);
1174+
std::ignore = hDevice;
11921175

11931176
// Look for an image for the NVPTX64 target, and return the first one that is
11941177
// found

‎sycl/plugins/unified_runtime/ur/adapters/cuda/enqueue.cpp

Lines changed: 1 addition & 72 deletions
Original file line numberDiff line numberDiff line change
@@ -228,8 +228,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueEventsWaitWithBarrier(
228228
const ur_event_handle_t *phEventWaitList, ur_event_handle_t *phEvent) {
229229
// This function makes one stream work on the previous work (or work
230230
// represented by input events) and then all future work waits on that stream.
231-
UR_ASSERT(hQueue, UR_RESULT_ERROR_INVALID_QUEUE);
232-
233231
ur_result_t Result;
234232

235233
try {
@@ -316,11 +314,8 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueKernelLaunch(
316314
const size_t *pLocalWorkSize, uint32_t numEventsInWaitList,
317315
const ur_event_handle_t *phEventWaitList, ur_event_handle_t *phEvent) {
318316
// Preconditions
319-
UR_ASSERT(hQueue, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
320317
UR_ASSERT(hQueue->getContext() == hKernel->getContext(),
321318
UR_RESULT_ERROR_INVALID_KERNEL);
322-
UR_ASSERT(hKernel, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
323-
UR_ASSERT(pGlobalWorkOffset, UR_RESULT_ERROR_INVALID_NULL_POINTER);
324319
UR_ASSERT(workDim > 0, UR_RESULT_ERROR_INVALID_WORK_DIMENSION);
325320
UR_ASSERT(workDim < 4, UR_RESULT_ERROR_INVALID_WORK_DIMENSION);
326321

@@ -537,9 +532,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueMemBufferReadRect(
537532
size_t hostRowPitch, size_t hostSlicePitch, void *pDst,
538533
uint32_t numEventsInWaitList, const ur_event_handle_t *phEventWaitList,
539534
ur_event_handle_t *phEvent) {
540-
UR_ASSERT(hBuffer, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
541-
UR_ASSERT(hQueue, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
542-
543535
ur_result_t Result = UR_RESULT_SUCCESS;
544536
CUdeviceptr DevPtr = hBuffer->Mem.BufferMem.get();
545537
std::unique_ptr<ur_event_handle_t_> RetImplEvent{nullptr};
@@ -588,9 +580,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueMemBufferWriteRect(
588580
size_t hostRowPitch, size_t hostSlicePitch, void *pSrc,
589581
uint32_t numEventsInWaitList, const ur_event_handle_t *phEventWaitList,
590582
ur_event_handle_t *phEvent) {
591-
UR_ASSERT(hBuffer, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
592-
UR_ASSERT(hQueue, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
593-
594583
ur_result_t Result = UR_RESULT_SUCCESS;
595584
CUdeviceptr DevPtr = hBuffer->Mem.BufferMem.get();
596585
std::unique_ptr<ur_event_handle_t_> RetImplEvent{nullptr};
@@ -636,8 +625,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueMemBufferCopy(
636625
ur_mem_handle_t hBufferDst, size_t srcOffset, size_t dstOffset, size_t size,
637626
uint32_t numEventsInWaitList, const ur_event_handle_t *phEventWaitList,
638627
ur_event_handle_t *phEvent) {
639-
UR_ASSERT(hQueue, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
640-
641628
std::unique_ptr<ur_event_handle_t_> RetImplEvent{nullptr};
642629

643630
try {
@@ -680,10 +667,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueMemBufferCopyRect(
680667
size_t srcSlicePitch, size_t dstRowPitch, size_t dstSlicePitch,
681668
uint32_t numEventsInWaitList, const ur_event_handle_t *phEventWaitList,
682669
ur_event_handle_t *phEvent) {
683-
UR_ASSERT(hBufferSrc, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
684-
UR_ASSERT(hBufferDst, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
685-
UR_ASSERT(hQueue, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
686-
687670
ur_result_t Result = UR_RESULT_SUCCESS;
688671
CUdeviceptr SrcPtr = hBufferSrc->Mem.BufferMem.get();
689672
CUdeviceptr DstPtr = hBufferDst->Mem.BufferMem.get();
@@ -723,8 +706,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueMemBufferFill(
723706
size_t patternSize, size_t offset, size_t size,
724707
uint32_t numEventsInWaitList, const ur_event_handle_t *phEventWaitList,
725708
ur_event_handle_t *phEvent) {
726-
UR_ASSERT(hQueue, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
727-
728709
auto ArgsAreMultiplesOfPatternSize =
729710
(offset % patternSize == 0) || (size % patternSize == 0);
730711

@@ -910,8 +891,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueMemImageRead(
910891
std::ignore = rowPitch;
911892
std::ignore = slicePitch;
912893

913-
UR_ASSERT(hQueue, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
914-
UR_ASSERT(hImage, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
915894
UR_ASSERT(hImage->MemType == ur_mem_handle_t_::Type::Surface,
916895
UR_RESULT_ERROR_INVALID_MEM_OBJECT);
917896

@@ -979,8 +958,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueMemImageWrite(
979958
std::ignore = rowPitch;
980959
std::ignore = slicePitch;
981960

982-
UR_ASSERT(hQueue, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
983-
UR_ASSERT(hImage, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
984961
UR_ASSERT(hImage->MemType == ur_mem_handle_t_::Type::Surface,
985962
UR_RESULT_ERROR_INVALID_MEM_OBJECT);
986963

@@ -1123,9 +1100,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueMemBufferMap(
11231100
ur_map_flags_t mapFlags, size_t offset, size_t size,
11241101
uint32_t numEventsInWaitList, const ur_event_handle_t *phEventWaitList,
11251102
ur_event_handle_t *phEvent, void **ppRetMap) {
1126-
UR_ASSERT(ppRetMap != nullptr, UR_RESULT_ERROR_INVALID_NULL_POINTER);
1127-
UR_ASSERT(hQueue != nullptr, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
1128-
UR_ASSERT(hBuffer != nullptr, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
11291103
UR_ASSERT(hBuffer->MemType == ur_mem_handle_t_::Type::Buffer,
11301104
UR_RESULT_ERROR_INVALID_MEM_OBJECT);
11311105

@@ -1184,10 +1158,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueMemUnmap(
11841158
uint32_t numEventsInWaitList, const ur_event_handle_t *phEventWaitList,
11851159
ur_event_handle_t *phEvent) {
11861160
ur_result_t Result = UR_RESULT_SUCCESS;
1187-
UR_ASSERT(hQueue, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
1188-
UR_ASSERT(hMem, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
1189-
UR_ASSERT(pMappedPtr, UR_RESULT_ERROR_INVALID_NULL_POINTER);
1190-
11911161
UR_ASSERT(hMem->MemType == ur_mem_handle_t_::Type::Buffer,
11921162
UR_RESULT_ERROR_INVALID_MEM_OBJECT);
11931163
UR_ASSERT(hMem->Mem.BufferMem.getMapPtr() != nullptr,
@@ -1233,10 +1203,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueUSMFill(
12331203
ur_queue_handle_t hQueue, void *ptr, size_t patternSize,
12341204
const void *pPattern, size_t size, uint32_t numEventsInWaitList,
12351205
const ur_event_handle_t *phEventWaitList, ur_event_handle_t *phEvent) {
1236-
UR_ASSERT(hQueue, UR_RESULT_ERROR_INVALID_QUEUE);
1237-
UR_ASSERT(ptr, UR_RESULT_ERROR_INVALID_NULL_POINTER);
1238-
UR_ASSERT(size % patternSize == 0, UR_RESULT_ERROR_INVALID_SIZE);
1239-
12401206
ur_result_t Result = UR_RESULT_SUCCESS;
12411207
std::unique_ptr<ur_event_handle_t_> EventPtr{nullptr};
12421208

@@ -1287,9 +1253,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueUSMMemcpy(
12871253
ur_queue_handle_t hQueue, bool blocking, void *pDst, const void *pSrc,
12881254
size_t size, uint32_t numEventsInWaitList,
12891255
const ur_event_handle_t *phEventWaitList, ur_event_handle_t *phEvent) {
1290-
UR_ASSERT(hQueue, UR_RESULT_ERROR_INVALID_QUEUE);
1291-
UR_ASSERT(pDst, UR_RESULT_ERROR_INVALID_NULL_POINTER);
1292-
UR_ASSERT(pSrc, UR_RESULT_ERROR_INVALID_NULL_POINTER);
12931256
ur_result_t Result = UR_RESULT_SUCCESS;
12941257

12951258
std::unique_ptr<ur_event_handle_t_> EventPtr{nullptr};
@@ -1326,7 +1289,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueUSMPrefetch(
13261289
ur_queue_handle_t hQueue, const void *pMem, size_t size,
13271290
ur_usm_migration_flags_t flags, uint32_t numEventsInWaitList,
13281291
const ur_event_handle_t *phEventWaitList, ur_event_handle_t *phEvent) {
1329-
UR_ASSERT(hQueue, UR_RESULT_ERROR_INVALID_QUEUE);
13301292
ur_device_handle_t Device = hQueue->getContext()->getDevice();
13311293

13321294
// Certain cuda devices and Windows do not have support for some Unified
@@ -1352,8 +1314,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueUSMPrefetch(
13521314
// flags is currently unused so fail if set
13531315
if (flags != 0)
13541316
return UR_RESULT_ERROR_INVALID_VALUE;
1355-
UR_ASSERT(hQueue, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
1356-
UR_ASSERT(pMem, UR_RESULT_ERROR_INVALID_NULL_POINTER);
1317+
13571318
ur_result_t Result = UR_RESULT_SUCCESS;
13581319
std::unique_ptr<ur_event_handle_t_> EventPtr{nullptr};
13591320

@@ -1384,9 +1345,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueUSMPrefetch(
13841345
UR_APIEXPORT ur_result_t UR_APICALL
13851346
urEnqueueUSMAdvise(ur_queue_handle_t hQueue, const void *pMem, size_t size,
13861347
ur_usm_advice_flags_t advice, ur_event_handle_t *phEvent) {
1387-
UR_ASSERT(hQueue, UR_RESULT_ERROR_INVALID_QUEUE);
1388-
UR_ASSERT(pMem, UR_RESULT_ERROR_INVALID_MEM_OBJECT);
1389-
13901348
// Certain cuda devices and Windows do not have support for some Unified
13911349
// Memory features. Passing CU_MEM_ADVISE_SET/CLEAR_PREFERRED_LOCATION and
13921350
// to cuMemAdvise on a GPU device requires the GPU device to report a non-zero
@@ -1473,7 +1431,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueUSMMemcpy2D(
14731431
const void *pSrc, size_t srcPitch, size_t width, size_t height,
14741432
uint32_t numEventsInWaitList, const ur_event_handle_t *phEventWaitList,
14751433
ur_event_handle_t *phEvent) {
1476-
UR_ASSERT(hQueue, UR_RESULT_ERROR_INVALID_QUEUE);
14771434
ur_result_t result = UR_RESULT_SUCCESS;
14781435

14791436
try {
@@ -1520,17 +1477,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueMemBufferRead(
15201477
ur_queue_handle_t hQueue, ur_mem_handle_t hBuffer, bool blockingRead,
15211478
size_t offset, size_t size, void *pDst, uint32_t numEventsInWaitList,
15221479
const ur_event_handle_t *phEventWaitList, ur_event_handle_t *phEvent) {
1523-
1524-
UR_ASSERT(hQueue, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
1525-
UR_ASSERT(hBuffer, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
15261480
UR_ASSERT(!hBuffer->isImage(), UR_RESULT_ERROR_INVALID_MEM_OBJECT);
1527-
UR_ASSERT(pDst, UR_RESULT_ERROR_INVALID_NULL_POINTER);
1528-
if (phEventWaitList) {
1529-
UR_ASSERT(numEventsInWaitList > 0, UR_RESULT_ERROR_INVALID_EVENT_WAIT_LIST);
1530-
} else {
1531-
UR_ASSERT(numEventsInWaitList == 0,
1532-
UR_RESULT_ERROR_INVALID_EVENT_WAIT_LIST);
1533-
}
15341481
UR_ASSERT(offset + size <= hBuffer->Mem.BufferMem.Size,
15351482
UR_RESULT_ERROR_INVALID_SIZE);
15361483

@@ -1577,17 +1524,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueMemBufferWrite(
15771524
ur_queue_handle_t hQueue, ur_mem_handle_t hBuffer, bool blockingWrite,
15781525
size_t offset, size_t size, const void *pSrc, uint32_t numEventsInWaitList,
15791526
const ur_event_handle_t *phEventWaitList, ur_event_handle_t *phEvent) {
1580-
1581-
UR_ASSERT(hQueue, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
1582-
UR_ASSERT(hBuffer, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
15831527
UR_ASSERT(!hBuffer->isImage(), UR_RESULT_ERROR_INVALID_MEM_OBJECT);
1584-
UR_ASSERT(pSrc, UR_RESULT_ERROR_INVALID_NULL_POINTER);
1585-
if (phEventWaitList) {
1586-
UR_ASSERT(numEventsInWaitList > 0, UR_RESULT_ERROR_INVALID_EVENT_WAIT_LIST);
1587-
} else {
1588-
UR_ASSERT(numEventsInWaitList == 0,
1589-
UR_RESULT_ERROR_INVALID_EVENT_WAIT_LIST);
1590-
}
15911528
UR_ASSERT(offset + size <= hBuffer->Mem.BufferMem.Size,
15921529
UR_RESULT_ERROR_INVALID_SIZE);
15931530

@@ -1633,10 +1570,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueDeviceGlobalVariableWrite(
16331570
bool blockingWrite, size_t count, size_t offset, const void *pSrc,
16341571
uint32_t numEventsInWaitList, const ur_event_handle_t *phEventWaitList,
16351572
ur_event_handle_t *phEvent) {
1636-
UR_ASSERT(hQueue, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
1637-
UR_ASSERT(hProgram, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
1638-
UR_ASSERT(name && pSrc, UR_RESULT_ERROR_INVALID_VALUE);
1639-
16401573
// Since CUDA requires a the global variable to be referenced by name, we use
16411574
// metadata to find the correct name to access it by.
16421575
auto DeviceGlobalNameIt = hProgram->GlobalIDMD.find(name);
@@ -1669,10 +1602,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueDeviceGlobalVariableRead(
16691602
bool blockingRead, size_t count, size_t offset, void *pDst,
16701603
uint32_t numEventsInWaitList, const ur_event_handle_t *phEventWaitList,
16711604
ur_event_handle_t *phEvent) {
1672-
UR_ASSERT(hQueue, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
1673-
UR_ASSERT(hProgram, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
1674-
UR_ASSERT(name && pDst, UR_RESULT_ERROR_INVALID_VALUE);
1675-
16761605
// Since CUDA requires a the global variable to be referenced by name, we use
16771606
// metadata to find the correct name to access it by.
16781607
auto DeviceGlobalNameIt = hProgram->GlobalIDMD.find(name);

0 commit comments

Comments
 (0)