Skip to content

Commit 0e3b6aa

Browse files
authored
[SYCL][NFC] Update tests for use_stall_enable_clusters attribute (#4060)
Signed-off-by: Soumi Manna <[email protected]>
1 parent 98ab6d7 commit 0e3b6aa

File tree

2 files changed

+8
-21
lines changed

2 files changed

+8
-21
lines changed

clang/test/CodeGenSYCL/stall_enable_device.cpp

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
// RUN: %clang_cc1 -fsycl-is-device -internal-isystem %S/Inputs -triple spir64-unknown-unknown-sycldevice -disable-llvm-passes -emit-llvm -o - %s | FileCheck %s
22

33
// Tests for IR of Intel FPGA [[intel::use_stall_enable_clusters]] function attribute on Device.
4-
// The metadata to be attached to the functionDecl that the attribute is applied to.
5-
// The attributes get propagated to the kernel metadata i.e. spir_kernel if directly applied
6-
// through functors/lambda function.
74

85
#include "sycl.hpp"
96

@@ -26,11 +23,6 @@ class Foo {
2623
[[intel::use_stall_enable_clusters]] void operator()() const {}
2724
};
2825

29-
class Functor {
30-
public:
31-
[[intel::use_stall_enable_clusters]] void operator()() const {}
32-
};
33-
3426
int main() {
3527
q.submit([&](handler &h) {
3628
// CHECK: define {{.*}}spir_kernel void @{{.*}}test_kernel1() {{.*}} !stall_enable ![[NUM4:[0-9]+]]
@@ -62,11 +54,6 @@ int main() {
6254
// CHECK: define {{.*}}spir_kernel void @{{.*}}test_kernel5() {{.*}} !stall_enable ![[NUM4]]
6355
h.single_task<class test_kernel5>(
6456
[]() [[intel::use_stall_enable_clusters]]{});
65-
66-
// CHECK: define {{.*}}spir_kernel void @{{.*}}test_kernel6() {{.*}} !stall_enable ![[NUM4]]
67-
// CHECK: define {{.*}}spir_func void @{{.*}}Functor{{.*}}(%class._ZTS7Functor.Functor addrspace(4)* align 1 dereferenceable_or_null(1) %this) #3 comdat align 2 !stall_enable ![[NUM4]]
68-
Functor f1;
69-
h.single_task<class test_kernel6>(f1);
7057
});
7158
return 0;
7259
}

clang/test/SemaSYCL/stall_enable_device.cpp

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ queue q;
1212
[[intel::use_stall_enable_clusters]] void func() {}
1313
// CHECK: FunctionDecl{{.*}}used func 'void ()'
1414
// CHECK-NEXT: CompoundStmt{{.*}}
15-
// CHECK-NEXT-NEXT: SYCLIntelUseStallEnableClustersAttr{{.*}}
15+
// CHECK-NEXT-NEXT: SYCLIntelUseStallEnableClustersAttr
1616

1717
// Tests for incorrect argument values for Intel FPGA use_stall_enable_clusters function attribute.
1818
#ifdef TRIGGER_ERROR
@@ -25,7 +25,7 @@ struct FuncObj {
2525
[[intel::use_stall_enable_clusters]] void operator()() const {}
2626
// CHECK: CXXRecordDecl{{.*}}implicit struct FuncObj
2727
// CHECK-NEXT: CXXMethodDecl{{.*}}used operator() 'void () const'
28-
// CHECK-NEXT-NEXT:SYCLIntelUseStallEnableClustersAttr{{.*}}
28+
// CHECK-NEXT-NEXT:SYCLIntelUseStallEnableClustersAttr
2929
};
3030

3131
// Test attribute is presented on lambda function(applied to a function type for the lambda's call operator).
@@ -34,15 +34,15 @@ void test3() {
3434
lambda();
3535
// CHECK: FunctionDecl{{.*}}test3
3636
// CHECK: LambdaExpr
37-
// CHECK: SYCLIntelUseStallEnableClustersAttr{{.*}}
37+
// CHECK: SYCLIntelUseStallEnableClustersAttr
3838
}
3939

4040
// Test attribute is presented on functor.
4141
// CHECK: CXXRecordDecl{{.*}}referenced class Functor definition
4242
// CHECK: CXXRecordDecl{{.*}} implicit class Functor
4343
// CHECK: AccessSpecDecl{{.*}} public
4444
// CHECK-NEXT: CXXMethodDecl{{.*}}used operator() 'void () const'
45-
// CHECK-NEXT-NEXT: SYCLIntelUseStallEnableClustersAttr{{.*}}
45+
// CHECK-NEXT-NEXT: SYCLIntelUseStallEnableClustersAttr
4646
class Functor {
4747
public:
4848
[[intel::use_stall_enable_clusters]] void operator()() const {
@@ -53,25 +53,25 @@ int main() {
5353
q.submit([&](handler &h) {
5454
// Test attribute is propagated to the kernel.
5555
// CHECK-LABEL: FunctionDecl {{.*}}test_kernel1
56-
// CHECK: SYCLIntelUseStallEnableClustersAttr {{.*}}
56+
// CHECK: SYCLIntelUseStallEnableClustersAttr
5757
h.single_task<class test_kernel1>(
5858
FuncObj());
5959

6060
// Test attribute is presented on LambdaExpr called by kernel.
6161
// CHECK-LABEL: FunctionDecl {{.*}}test_kernel2
62-
// CHECK-: SYCLIntelUseStallEnableClustersAttr {{.*}}
62+
// CHECK: SYCLIntelUseStallEnableClustersAttr
6363
h.single_task<class test_kernel2>(
6464
[]() [[intel::use_stall_enable_clusters]]{});
6565

6666
// Test attribute is not propagated to the kernel.
6767
// CHECK-LABEL: FunctionDecl {{.*}}test_kernel3
68-
// CHECK-NOT: SYCLIntelUseStallEnableClustersAttr {{.*}}
68+
// CHECK-NOT: SYCLIntelUseStallEnableClustersAttr
6969
h.single_task<class test_kernel3>(
7070
[]() { func(); });
7171

7272
// Test attribute is applied to kernel if directly applied through functor.
7373
// CHECK-LABEL: FunctionDecl {{.*}}test_kernel4
74-
// CHECK: SYCLIntelUseStallEnableClustersAttr {{.*}}
74+
// CHECK: SYCLIntelUseStallEnableClustersAttr
7575
Functor f2;
7676
h.single_task<class test_kernel4>(f2);
7777
});

0 commit comments

Comments
 (0)