Skip to content

Commit 0ecd023

Browse files
committed
changes requested by reviewers
Signed-off-by: Chris Perkins <[email protected]>
1 parent da71fe9 commit 0ecd023

File tree

3 files changed

+6
-7
lines changed

3 files changed

+6
-7
lines changed

clang/include/clang/Sema/Sema.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -370,7 +370,7 @@ class SYCLIntegrationHeader {
370370
KernelParamDesc() = default;
371371
};
372372

373-
// there are four free function the kernel may call (this_id, this_item,
373+
// there are four free functions the kernel may call (this_id, this_item,
374374
// this_nd_item, this_group)
375375
struct KernelCallsSYCLFreeFunction {
376376
bool CallsThisId;

clang/lib/Sema/SemaSYCL.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2721,7 +2721,7 @@ class SyclKernelIntHeaderCreator : public SyclKernelFieldHandler {
27212721
if (!Visited.insert(FD).second)
27222722
continue; // We've already seen this Decl
27232723

2724-
// Check whether this call is to free functions ( sycl::this_item(),
2724+
// Check whether this call is to free functions (sycl::this_item(),
27252725
// this_id, etc.).
27262726
if (Util::isSyclFunction(FD, "this_id")) {
27272727
Header.setCallsThisId(true);
@@ -4001,25 +4001,25 @@ void SYCLIntegrationHeader::addSpecConstant(StringRef IDName, QualType IDType) {
40014001

40024002
void SYCLIntegrationHeader::setCallsThisId(bool B) {
40034003
KernelDesc *K = getCurKernelDesc();
4004-
assert(K && "no kernels");
4004+
assert(K && "no kernel");
40054005
K->FreeFunctionCalls.CallsThisId = B;
40064006
}
40074007

40084008
void SYCLIntegrationHeader::setCallsThisItem(bool B) {
40094009
KernelDesc *K = getCurKernelDesc();
4010-
assert(K && "no kernels");
4010+
assert(K && "no kernel");
40114011
K->FreeFunctionCalls.CallsThisItem = B;
40124012
}
40134013

40144014
void SYCLIntegrationHeader::setCallsThisNDItem(bool B) {
40154015
KernelDesc *K = getCurKernelDesc();
4016-
assert(K && "no kernels");
4016+
assert(K && "no kernel");
40174017
K->FreeFunctionCalls.CallsThisNDItem = B;
40184018
}
40194019

40204020
void SYCLIntegrationHeader::setCallsThisGroup(bool B) {
40214021
KernelDesc *K = getCurKernelDesc();
4022-
assert(K && "no kernels");
4022+
assert(K && "no kernel");
40234023
K->FreeFunctionCalls.CallsThisGroup = B;
40244024
}
40254025

sycl/include/CL/sycl/detail/cg_types.hpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
#include <CL/sycl/detail/host_profiling_info.hpp>
1212
#include <CL/sycl/detail/kernel_desc.hpp>
1313
#include <CL/sycl/group.hpp>
14-
//#include <CL/sycl/handler.hpp>
1514
#include <CL/sycl/id.hpp>
1615
#include <CL/sycl/interop_handle.hpp>
1716
#include <CL/sycl/interop_handler.hpp>

0 commit comments

Comments
 (0)