Skip to content

Commit 0f19c60

Browse files
committed
[gn build] Don't set LLVM_UNREACHABLE_OPTIMIZE when llvm_enable_assertions
llvm_unreachable should properly error out if assertions are enabled. Reviewed By: thakis Differential Revision: https://reviews.llvm.org/D134332
1 parent b9735db commit 0f19c60

File tree

1 file changed

+6
-1
lines changed
  • llvm/utils/gn/secondary/llvm/include/llvm/Config

1 file changed

+6
-1
lines changed

llvm/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -329,7 +329,6 @@ write_cmake_config("llvm-config") {
329329
"LLVM_HAVE_TFLITE=",
330330
"LLVM_HOST_TRIPLE=$llvm_current_triple",
331331
"LLVM_NATIVE_ARCH=$native_target",
332-
"LLVM_UNREACHABLE_OPTIMIZE=1",
333332
"LLVM_USE_INTEL_JITEVENTS=",
334333
"LLVM_USE_OPROFILE=",
335334
"LLVM_USE_PERF=",
@@ -340,6 +339,12 @@ write_cmake_config("llvm-config") {
340339
"PACKAGE_VERSION=${llvm_version}git",
341340
]
342341

342+
if (llvm_enable_assertions) {
343+
values += [ "LLVM_UNREACHABLE_OPTIMIZE=" ]
344+
} else {
345+
values += [ "LLVM_UNREACHABLE_OPTIMIZE=1" ]
346+
}
347+
343348
if (llvm_build_native) {
344349
values += [
345350
"LLVM_NATIVE_ASMPARSER=1",

0 commit comments

Comments
 (0)