Skip to content

Commit 11e7c4d

Browse files
authored
[Sycl][Graph] Remove SYCL_EXPORT from template to fix build error (#17005)
PR #16788 broke the windows post-commit CI when building with `icx`/`icpx` https://github.com/intel/llvm/actions/runs/13310637099/job/37172065867 ``` D:\github\_work\llvm\llvm\build\include\sycl\ext\oneapi\experimental\graph.hpp(577,8): error: 'dllexport' attribute ignored [-Werror,-Wignored-attributes] 577 | struct __SYCL_EXPORT | ^ D:\github\_work\llvm\llvm\build\include\sycl\detail\export.hpp(23,34): note: expanded from macro '__SYCL_EXPORT' 23 | #define __SYCL_EXPORT __declspec(dllexport) | ^ In file included from D:\github\_work\llvm\llvm\src\sycl\unittests\Extensions\EventMode.cpp:9: In file included from D:\github\_work\llvm\llvm\build\include\sycl\sycl.hpp:11: In file included from D:\github\_work\llvm\llvm\build\include\sycl\detail\core.hpp:23: In file included from D:\github\_work\llvm\llvm\build\include\sycl\queue.hpp:34: D:\github\_work\llvm\llvm\build\include\sycl\ext\oneapi\experimental\graph.hpp(587,8): error: 'dllexport' attribute ignored [-Werror,-Wignored-attributes] 587 | struct __SYCL_EXPORT | ^ D:\github\_work\llvm\llvm\build\include\sycl\detail\export.hpp(23,34): note: expanded from macro '__SYCL_EXPORT' 23 | #define __SYCL_EXPORT __declspec(dllexport) | ^ 2 errors generated. ``` Fix by not exporting these symbols
1 parent f3d12f0 commit 11e7c4d

File tree

1 file changed

+2
-4
lines changed
  • sycl/include/sycl/ext/oneapi/experimental

1 file changed

+2
-4
lines changed

sycl/include/sycl/ext/oneapi/experimental/graph.hpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -574,8 +574,7 @@ struct __SYCL_EXPORT
574574
};
575575

576576
template <sycl::ext::oneapi::experimental::graph_state State>
577-
struct __SYCL_EXPORT
578-
hash<sycl::ext::oneapi::experimental::command_graph<State>> {
577+
struct hash<sycl::ext::oneapi::experimental::command_graph<State>> {
579578
size_t operator()(const sycl::ext::oneapi::experimental::command_graph<State>
580579
&Graph) const {
581580
auto ID = sycl::detail::getSyclObjImpl(Graph)->getID();
@@ -584,8 +583,7 @@ struct __SYCL_EXPORT
584583
};
585584

586585
template <typename ValueT>
587-
struct __SYCL_EXPORT
588-
hash<sycl::ext::oneapi::experimental::dynamic_parameter<ValueT>> {
586+
struct hash<sycl::ext::oneapi::experimental::dynamic_parameter<ValueT>> {
589587
size_t
590588
operator()(const sycl::ext::oneapi::experimental::dynamic_parameter<ValueT>
591589
&DynamicParam) const {

0 commit comments

Comments
 (0)