Skip to content

Commit 157dae5

Browse files
svenvhjsji
authored andcommitted
SPIRVReader: Add OpCopyMemory support (#2779)
Add support for translating `OpCopyMemory` into `llvm.memcpy`. Fixes KhronosGroup/SPIRV-LLVM-Translator#2769 Original commit: KhronosGroup/SPIRV-LLVM-Translator@8dc0349c0860172
1 parent bd16a00 commit 157dae5

File tree

2 files changed

+74
-5
lines changed

2 files changed

+74
-5
lines changed

llvm-spirv/lib/SPIRV/SPIRVReader.cpp

Lines changed: 23 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1816,9 +1816,28 @@ Value *SPIRVToLLVM::transValueWithoutDecoration(SPIRVValue *BV, Function *F,
18161816
return mapValue(BV, LI);
18171817
}
18181818

1819+
case OpCopyMemory: {
1820+
auto *BC = static_cast<SPIRVCopyMemory *>(BV);
1821+
llvm::Value *Dst = transValue(BC->getTarget(), F, BB);
1822+
MaybeAlign Align(BC->getAlignment());
1823+
MaybeAlign SrcAlign =
1824+
BC->getSrcAlignment() ? MaybeAlign(BC->getSrcAlignment()) : Align;
1825+
Type *EltTy =
1826+
transType(BC->getSource()->getType()->getPointerElementType());
1827+
uint64_t Size = M->getDataLayout().getTypeStoreSize(EltTy).getFixedValue();
1828+
bool IsVolatile = BC->SPIRVMemoryAccess::isVolatile();
1829+
IRBuilder<> Builder(BB);
1830+
1831+
llvm::Value *Src = transValue(BC->getSource(), F, BB);
1832+
CallInst *CI =
1833+
Builder.CreateMemCpy(Dst, Align, Src, SrcAlign, Size, IsVolatile);
1834+
if (isFuncNoUnwind())
1835+
CI->getFunction()->addFnAttr(Attribute::NoUnwind);
1836+
return mapValue(BV, CI);
1837+
}
1838+
18191839
case OpCopyMemorySized: {
18201840
SPIRVCopyMemorySized *BC = static_cast<SPIRVCopyMemorySized *>(BV);
1821-
CallInst *CI = nullptr;
18221841
llvm::Value *Dst = transValue(BC->getTarget(), F, BB);
18231842
MaybeAlign Align(BC->getAlignment());
18241843
MaybeAlign SrcAlign =
@@ -1827,10 +1846,9 @@ Value *SPIRVToLLVM::transValueWithoutDecoration(SPIRVValue *BV, Function *F,
18271846
bool IsVolatile = BC->SPIRVMemoryAccess::isVolatile();
18281847
IRBuilder<> Builder(BB);
18291848

1830-
if (!CI) {
1831-
llvm::Value *Src = transValue(BC->getSource(), F, BB);
1832-
CI = Builder.CreateMemCpy(Dst, Align, Src, SrcAlign, Size, IsVolatile);
1833-
}
1849+
llvm::Value *Src = transValue(BC->getSource(), F, BB);
1850+
CallInst *CI =
1851+
Builder.CreateMemCpy(Dst, Align, Src, SrcAlign, Size, IsVolatile);
18341852
if (isFuncNoUnwind())
18351853
CI->getFunction()->addFnAttr(Attribute::NoUnwind);
18361854
return mapValue(BV, CI);

llvm-spirv/test/OpCopyMemory.spvasm

Lines changed: 51 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,51 @@
1+
; Check SPIRVReader support for OpCopyMemory.
2+
3+
; REQUIRES: spirv-as
4+
; RUN: spirv-as --target-env spv1.0 -o %t.spv %s
5+
; RUN: spirv-val %t.spv
6+
; RUN: llvm-spirv -r %t.spv -o %t.rev.bc
7+
; RUN: llvm-dis %t.rev.bc -o - | FileCheck %s
8+
9+
OpCapability Addresses
10+
OpCapability Int16
11+
OpCapability Kernel
12+
OpMemoryModel Physical64 OpenCL
13+
OpEntryPoint Kernel %kernel "copymemory"
14+
OpName %pStruct "pStruct"
15+
OpName %dstStruct "dstStruct"
16+
OpName %pShort "pShort"
17+
OpName %dstShort "dstShort"
18+
OpName %pInt "pInt"
19+
OpName %dstInt "dstInt"
20+
%ushort = OpTypeInt 16 0
21+
%uint = OpTypeInt 32 0
22+
%struct = OpTypeStruct %ushort %uint %ushort
23+
%void = OpTypeVoid
24+
%gptr_struct = OpTypePointer CrossWorkgroup %struct
25+
%pptr_struct = OpTypePointer Function %struct
26+
%gptr_short = OpTypePointer CrossWorkgroup %ushort
27+
%pptr_short = OpTypePointer Function %ushort
28+
%gptr_int = OpTypePointer CrossWorkgroup %uint
29+
%pptr_int = OpTypePointer Function %uint
30+
%kernel_sig = OpTypeFunction %void %gptr_short %gptr_int %gptr_struct
31+
%ushort_42 = OpConstant %ushort 42
32+
%uint_4242 = OpConstant %uint 4242
33+
%struct_init = OpConstantComposite %struct %ushort_42 %uint_4242 %ushort_42
34+
%kernel = OpFunction %void None %kernel_sig
35+
%dstShort = OpFunctionParameter %gptr_short
36+
%dstInt = OpFunctionParameter %gptr_int
37+
%dstStruct = OpFunctionParameter %gptr_struct
38+
%entry = OpLabel
39+
%pShort = OpVariable %pptr_short Function %ushort_42
40+
%pInt = OpVariable %pptr_int Function %uint_4242
41+
%pStruct = OpVariable %pptr_struct Function %struct_init
42+
OpCopyMemory %dstShort %pShort
43+
OpCopyMemory %dstInt %pInt
44+
OpCopyMemory %dstStruct %pStruct
45+
OpReturn
46+
OpFunctionEnd
47+
48+
; CHECK-LABEL: define spir_kernel void @copymemory(ptr addrspace(1) %dstShort, ptr addrspace(1) %dstInt, ptr addrspace(1) %dstStruct)
49+
; CHECK: call void @llvm.memcpy.p1.p0.i64(ptr addrspace(1) %dstShort, ptr @pShort, i64 2, i1 false)
50+
; CHECK: call void @llvm.memcpy.p1.p0.i64(ptr addrspace(1) %dstInt, ptr @pInt, i64 4, i1 false)
51+
; CHECK: call void @llvm.memcpy.p1.p0.i64(ptr addrspace(1) %dstStruct, ptr @pStruct, i64 12, i1 false)

0 commit comments

Comments
 (0)