[SYCL][RTC] Make JIT-based pipeline the default for SYCL language (#17383)

Remove the invoke-based implementation and the temporary
`source_language::sycl_jit` - the in-memory pipeline now handles
`source_language::sycl`.

---------

Signed-off-by: Julian Oppermann <[email protected]>

Author: jopperm

sycl/include/sycl/kernel_bundle_enums.hpp

@@ -25,7 +25,6 @@ enum class source_language : int {
   spirv = 1,
   sycl = 2,
   /* cuda */
-  sycl_jit = 99 /* temporary, alternative implementation for SYCL */
 };
 
 // opencl versions

sycl/source/detail/kernel_bundle_impl.hpp

@@ -377,7 +377,7 @@ class kernel_bundle_impl {
   }
 
   // oneapi_ext_kernel_compiler
-  // program manager integration, only for sycl_jit language
+  // program manager integration, only for sycl language
   kernel_bundle_impl(
       context Ctx, std::vector<device> Devs,
       const std::vector<kernel_id> &KernelIDs,
@@ -387,7 +387,7 @@ class kernel_bundle_impl {
       syclex::source_language Lang)
       : kernel_bundle_impl(std::move(Ctx), std::move(Devs), KernelIDs,
                            bundle_state::executable) {
-    assert(Lang == syclex::source_language::sycl_jit);
+    assert(Lang == syclex::source_language::sycl);
     // Mark this bundle explicitly as "interop" to ensure that its kernels are
     // enqueued with the info from the kernel object passed by the application,
     // cf. `enqueueImpKernel` in `commands.cpp`. While runtime-compiled kernels
@@ -513,7 +513,7 @@ class kernel_bundle_impl {
       DeviceVec.push_back(Dev);
     }
 
-    if (MLanguage == syclex::source_language::sycl_jit) {
+    if (MLanguage == syclex::source_language::sycl) {
       // Build device images via the program manager.
       const std::string &SourceStr = std::get<std::string>(MSource);
       std::ostringstream SourceExt;
@@ -536,7 +536,7 @@ class kernel_bundle_impl {
         SourceExt << ")]];\n";
       }
 
-      auto [Binaries, Prefix] = syclex::detail::SYCL_JIT_to_SPIRV(
+      auto [Binaries, Prefix] = syclex::detail::SYCL_JIT_Compile(
           RegisteredKernelNames.empty() ? SourceStr : SourceExt.str(),
           MIncludePairs, BuildOptions, LogPtr);
 
@@ -616,11 +616,6 @@ class kernel_bundle_impl {
                          [](std::byte B) { return static_cast<uint8_t>(B); });
           return Result;
         }
-        if (MLanguage == syclex::source_language::sycl) {
-          return syclex::detail::SYCL_to_SPIRV(*SourceStrPtr, MIncludePairs,
-                                               BuildOptions, LogPtr,
-                                               RegisteredKernelNames);
-        }
         throw sycl::exception(
             make_error_code(errc::invalid),
             "SYCL C++, OpenCL C and SPIR-V are the only supported "
@@ -686,16 +681,11 @@ class kernel_bundle_impl {
   }
 
   std::string adjust_kernel_name(const std::string &Name) {
-    if (MLanguage == syclex::source_language::sycl_jit) {
+    if (MLanguage == syclex::source_language::sycl) {
       auto It = MMangledKernelNames.find(Name);
       return It == MMangledKernelNames.end() ? Name : It->second;
     }
 
-    if (MLanguage == syclex::source_language::sycl) {
-      bool isMangled = Name.find("__sycl_kernel_") != std::string::npos;
-      return isMangled ? Name : "__sycl_kernel_" + Name;
-    }
-
     return Name;
   }
 
@@ -722,7 +712,7 @@ class kernel_bundle_impl {
       throw sycl::exception(make_error_code(errc::invalid),
                             "kernel '" + Name + "' not found in kernel_bundle");
 
-    if (MLanguage == syclex::source_language::sycl_jit) {
+    if (MLanguage == syclex::source_language::sycl) {
       auto &PM = ProgramManager::getInstance();
       auto KID = PM.getSYCLKernelID(MPrefix + AdjustedName);
 
@@ -1010,7 +1000,7 @@ class kernel_bundle_impl {
     try {
       if (MDeviceBinaries) {
         ProgramManager::getInstance().removeImages(MDeviceBinaries);
-        syclex::detail::SYCL_JIT_destroy(MDeviceBinaries);
+        syclex::detail::SYCL_JIT_Destroy(MDeviceBinaries);
       }
     } catch (std::exception &e) {
       __SYCL_REPORT_EXCEPTION_TO_STREAM("exception in ~kernel_bundle_impl", e);