Skip to content

Commit 1754c58

Browse files
authored
[SYCL][Graph][L0] Reset L0 events for UR sync-points (#11553)
The [Unified Runtime sync-points](https://oneapi-src.github.io/unified-runtime/core/EXP-COMMAND-BUFFER.html#sync-points) used to represent SYCL-Graph edges have a bug in the implementation of the Level Zero adapter. The L0 events used to implement the sync-points are not reset to the non-signaled state after an enqueue of the graph. Fixed in the UR L0 adapter change oneapi-src/unified-runtime#965 which resets the UR events to the non-signaled state at the end of the L0 command-list.
1 parent a87bb8b commit 1754c58

File tree

3 files changed

+10
-23
lines changed

3 files changed

+10
-23
lines changed

sycl/doc/design/CommandGraph.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,9 @@ created on UR command-buffer enqueue.
163163

164164
There is also a *WaitEvent* used by the `ur_exp_command_buffer_handle_t` class
165165
in the prefix to wait on any dependencies passed in the enqueue wait-list.
166+
This WaitEvent is reset at the end of the suffix, along with reset commands
167+
to reset the L0 events used to implement the UR sync-points back to the
168+
non-signaled state.
166169

167170
![L0 command-buffer diagram](images/L0_UR_command-buffer.svg)
168171

Lines changed: 1 addition & 17 deletions
Loading

sycl/plugins/unified_runtime/CMakeLists.txt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -54,13 +54,13 @@ if(SYCL_PI_UR_USE_FETCH_CONTENT)
5454
include(FetchContent)
5555

5656
set(UNIFIED_RUNTIME_REPO "https://github.com/oneapi-src/unified-runtime.git")
57-
# commit cf26de283a1233e6c93feb085acc10c566888b59
58-
# Merge: 3a3aae38 2fd9dea2
57+
# commit: 7c8617b3710736db642585fe310a64e19e059d2e
58+
# Merge: 20d4f49 9a13af
5959
# Author: Kenneth Benzie (Benie) <[email protected]>
60-
# Date: Wed Oct 25 10:36:48 2023 +0100
61-
# Merge pull request #940 from Naghasan/victor/kernel-fusion-amd
62-
# [UR][HIP] Enable kernel finalization using comgr
63-
set(UNIFIED_RUNTIME_TAG cf26de283a1233e6c93feb085acc10c566888b59)
60+
# Date: Thu Oct 26 10:20:03 2023 +0100
61+
# Merge pull request #965 from Bensuo/ewan/L0_internal_event_fix
62+
# [Command-buffer][L0] Reset sync-point events
63+
set(UNIFIED_RUNTIME_TAG 7c8617b3710736db642585fe310a64e19e059d2e)
6464

6565
if(SYCL_PI_UR_OVERRIDE_FETCH_CONTENT_REPO)
6666
set(UNIFIED_RUNTIME_REPO "${SYCL_PI_UR_OVERRIDE_FETCH_CONTENT_REPO}")

0 commit comments

Comments
 (0)