Skip to content

Commit 1830bd1

Browse files
committed
Update test style.
Signed-off-by: James Brodman <[email protected]>
1 parent 56d376f commit 1830bd1

13 files changed

+474
-477
lines changed

sycl/test/usm/allocator_vector.cpp

Lines changed: 22 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -25,33 +25,35 @@ int main() {
2525
auto dev = q.get_device();
2626
auto ctxt = q.get_context();
2727

28-
if (dev.get_info<info::device::usm_host_allocations>()) {
29-
usm_allocator<int, usm::alloc::host> alloc(ctxt, dev);
28+
if (!dev.get_info<info::device::usm_host_allocations>())
29+
return 0;
3030

31-
std::vector<int, decltype(alloc)> vec(alloc);
32-
vec.resize(N);
31+
usm_allocator<int, usm::alloc::host> alloc(ctxt, dev);
3332

34-
for (int i = 0; i < N; i++) {
35-
vec[i] = i;
36-
}
33+
std::vector<int, decltype(alloc)> vec(alloc);
34+
vec.resize(N);
3735

38-
int *res = &vec[0];
39-
int *vals = &vec[0];
36+
for (int i = 0; i < N; i++) {
37+
vec[i] = i;
38+
}
39+
40+
int *res = &vec[0];
41+
int *vals = &vec[0];
4042

41-
auto e1 = q.submit([=](handler &cgh) {
42-
cgh.single_task<class foo>([=]() {
43-
for (int i = 1; i < N; i++) {
44-
res[0] += vals[i];
45-
}
46-
});
43+
auto e1 = q.submit([=](handler &cgh) {
44+
cgh.single_task<class foo>([=]() {
45+
for (int i = 1; i < N; i++) {
46+
res[0] += vals[i];
47+
}
4748
});
49+
});
4850

49-
e1.wait();
51+
e1.wait();
5052

51-
int answer = (N * (N - 1)) / 2;
53+
int answer = (N * (N - 1)) / 2;
54+
55+
if (vec[0] != answer)
56+
return -1;
5257

53-
if (vec[0] != answer)
54-
return -1;
55-
}
5658
return 0;
5759
}

sycl/test/usm/allocatorll.cpp

Lines changed: 36 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -30,55 +30,54 @@ int main() {
3030
auto dev = q.get_device();
3131
auto ctxt = q.get_context();
3232

33-
if (dev.get_info<info::device::usm_device_allocations>()) {
34-
usm_allocator<Node, usm::alloc::device> alloc(ctxt, dev);
33+
if (!dev.get_info<info::device::usm_device_allocations>())
34+
return 0;
3535

36-
Node *d_head = nullptr;
37-
Node *d_cur = nullptr;
38-
Node h_cur;
36+
usm_allocator<Node, usm::alloc::device> alloc(ctxt, dev);
37+
Node h_cur;
3938

40-
d_head = alloc.allocate(1);
41-
d_cur = d_head;
39+
Node *d_head = alloc.allocate(1);
40+
Node *d_cur = d_head;
4241

43-
for (int i = 0; i < numNodes; i++) {
44-
h_cur.Num = i * 2;
42+
for (int i = 0; i < numNodes; i++) {
43+
h_cur.Num = i * 2;
4544

46-
if (i != (numNodes - 1)) {
47-
h_cur.pNext = alloc.allocate(1);
48-
} else {
49-
h_cur.pNext = nullptr;
50-
}
45+
if (i != (numNodes - 1)) {
46+
h_cur.pNext = alloc.allocate(1);
47+
} else {
48+
h_cur.pNext = nullptr;
49+
}
5150

52-
event e0 = q.memcpy(d_cur, &h_cur, sizeof(Node));
53-
e0.wait();
51+
event e0 = q.memcpy(d_cur, &h_cur, sizeof(Node));
52+
e0.wait();
5453

55-
d_cur = h_cur.pNext;
56-
}
54+
d_cur = h_cur.pNext;
55+
}
5756

58-
auto e1 = q.submit([=](handler &cgh) {
59-
cgh.single_task<class foo>([=]() {
60-
Node *pHead = d_head;
61-
while (pHead) {
62-
pHead->Num = pHead->Num * 2 + 1;
63-
pHead = pHead->pNext;
64-
}
65-
});
57+
auto e1 = q.submit([=](handler &cgh) {
58+
cgh.single_task<class foo>([=]() {
59+
Node *pHead = d_head;
60+
while (pHead) {
61+
pHead->Num = pHead->Num * 2 + 1;
62+
pHead = pHead->pNext;
63+
}
6664
});
65+
});
6766

68-
e1.wait();
67+
e1.wait();
6968

70-
d_cur = d_head;
71-
for (int i = 0; i < numNodes; i++) {
72-
event c = q.memcpy(&h_cur, d_cur, sizeof(Node));
73-
c.wait();
74-
alloc.deallocate(d_cur, 1);
69+
d_cur = d_head;
70+
for (int i = 0; i < numNodes; i++) {
71+
event c = q.memcpy(&h_cur, d_cur, sizeof(Node));
72+
c.wait();
73+
alloc.deallocate(d_cur, 1);
7574

76-
const int want = i * 4 + 1;
77-
if (h_cur.Num != want) {
78-
return -1;
79-
}
80-
d_cur = h_cur.pNext;
75+
const int want = i * 4 + 1;
76+
if (h_cur.Num != want) {
77+
return -2;
8178
}
79+
d_cur = h_cur.pNext;
8280
}
81+
8382
return 0;
8483
}

sycl/test/usm/depends_on.cpp

Lines changed: 42 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -17,66 +17,65 @@ using namespace cl::sycl;
1717

1818
class foo;
1919
int main() {
20-
int *darray = nullptr;
21-
int *sarray = nullptr;
22-
int *harray = nullptr;
2320
const int N = 4;
2421
const int MAGIC_NUM = 42;
2522

2623
queue q;
2724
auto dev = q.get_device();
2825
auto ctxt = q.get_context();
2926

30-
if (dev.get_info<info::device::usm_device_allocations>() &&
31-
dev.get_info<info::device::usm_host_allocations>() &&
32-
dev.get_info<info::device::usm_shared_allocations>()) {
33-
darray = (int *)malloc_device(N * sizeof(int), dev, ctxt);
34-
if (darray == nullptr) {
35-
return -1;
36-
}
37-
sarray = (int *)malloc_shared(N * sizeof(int), dev, ctxt);
27+
if (!(dev.get_info<info::device::usm_device_allocations>() &&
28+
dev.get_info<info::device::usm_host_allocations>() &&
29+
dev.get_info<info::device::usm_shared_allocations>()))
30+
return 0;
3831

39-
if (sarray == nullptr) {
40-
return -1;
41-
}
32+
int *darray = (int *)malloc_device(N * sizeof(int), dev, ctxt);
33+
if (darray == nullptr) {
34+
return -1;
35+
}
36+
int *sarray = (int *)malloc_shared(N * sizeof(int), dev, ctxt);
4237

43-
harray = (int *)malloc_host(N * sizeof(int), ctxt);
44-
if (harray == nullptr) {
45-
return -1;
46-
}
38+
if (sarray == nullptr) {
39+
return -1;
40+
}
4741

48-
event e;
49-
auto eInit = q.submit([&](handler &cgh) {
50-
cgh.depends_on(e);
51-
cgh.single_task<class init>([=]() {
52-
for (int i = 0; i < N; i++) {
53-
sarray[i] = MAGIC_NUM - 1;
54-
harray[i] = 1;
55-
}
56-
});
42+
int *harray = (int *)malloc_host(N * sizeof(int), ctxt);
43+
if (harray == nullptr) {
44+
return -1;
45+
}
46+
47+
event e;
48+
auto eInit = q.submit([&](handler &cgh) {
49+
cgh.depends_on(e);
50+
cgh.single_task<class init>([=]() {
51+
for (int i = 0; i < N; i++) {
52+
sarray[i] = MAGIC_NUM - 1;
53+
harray[i] = 1;
54+
}
5755
});
56+
});
5857

59-
auto eMemset = q.memset(darray, 0, N * sizeof(int));
58+
auto eMemset = q.memset(darray, 0, N * sizeof(int));
6059

61-
auto eKernel = q.submit([=](handler &cgh) {
62-
cgh.depends_on({eInit, eMemset});
63-
cgh.single_task<class foo>([=]() {
64-
for (int i = 0; i < N; i++) {
65-
sarray[i] += darray[i] + harray[i];
66-
}
67-
});
60+
auto eKernel = q.submit([=](handler &cgh) {
61+
cgh.depends_on({eInit, eMemset});
62+
cgh.single_task<class foo>([=]() {
63+
for (int i = 0; i < N; i++) {
64+
sarray[i] += darray[i] + harray[i];
65+
}
6866
});
67+
});
6968

70-
eKernel.wait();
69+
eKernel.wait();
7170

72-
for (int i = 0; i < N; i++) {
73-
if (sarray[i] != MAGIC_NUM) {
74-
return -1;
75-
}
71+
for (int i = 0; i < N; i++) {
72+
if (sarray[i] != MAGIC_NUM) {
73+
return -2;
7674
}
77-
free(darray, ctxt);
78-
free(sarray, ctxt);
79-
free(harray, ctxt);
8075
}
76+
free(darray, ctxt);
77+
free(sarray, ctxt);
78+
free(harray, ctxt);
79+
8180
return 0;
8281
}

sycl/test/usm/dmemll.cpp

Lines changed: 44 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -30,59 +30,59 @@ int main() {
3030
auto dev = q.get_device();
3131
auto ctxt = q.get_context();
3232

33-
if (dev.get_info<info::device::usm_device_allocations>()) {
34-
Node *d_head = nullptr;
35-
Node *d_cur = nullptr;
36-
Node h_cur;
37-
38-
d_head = (Node *)malloc_device(sizeof(Node), dev, ctxt);
39-
if (d_head == nullptr) {
40-
return -1;
41-
}
42-
d_cur = d_head;
43-
44-
for (int i = 0; i < numNodes; i++) {
45-
h_cur.Num = i * 2;
46-
47-
if (i != (numNodes - 1)) {
48-
h_cur.pNext = (Node *)malloc_device(sizeof(Node), dev, ctxt);
49-
if (h_cur.pNext == nullptr) {
50-
return -1;
51-
}
52-
} else {
53-
h_cur.pNext = nullptr;
54-
}
33+
if (!dev.get_info<info::device::usm_device_allocations>())
34+
return 0;
5535

56-
event e0 = q.memcpy(d_cur, &h_cur, sizeof(Node));
57-
e0.wait();
36+
Node h_cur;
37+
38+
Node *d_head = (Node *)malloc_device(sizeof(Node), dev, ctxt);
39+
if (d_head == nullptr) {
40+
return -1;
41+
}
42+
Node *d_cur = d_head;
5843

59-
d_cur = h_cur.pNext;
44+
for (int i = 0; i < numNodes; i++) {
45+
h_cur.Num = i * 2;
46+
47+
if (i != (numNodes - 1)) {
48+
h_cur.pNext = (Node *)malloc_device(sizeof(Node), dev, ctxt);
49+
if (h_cur.pNext == nullptr) {
50+
return -1;
51+
}
52+
} else {
53+
h_cur.pNext = nullptr;
6054
}
6155

62-
auto e1 = q.submit([=](handler &cgh) {
63-
cgh.single_task<class foo>([=]() {
64-
Node *pHead = d_head;
65-
while (pHead) {
66-
pHead->Num = pHead->Num * 2 + 1;
67-
pHead = pHead->pNext;
68-
}
69-
});
56+
event e0 = q.memcpy(d_cur, &h_cur, sizeof(Node));
57+
e0.wait();
58+
59+
d_cur = h_cur.pNext;
60+
}
61+
62+
auto e1 = q.submit([=](handler &cgh) {
63+
cgh.single_task<class foo>([=]() {
64+
Node *pHead = d_head;
65+
while (pHead) {
66+
pHead->Num = pHead->Num * 2 + 1;
67+
pHead = pHead->pNext;
68+
}
7069
});
70+
});
7171

72-
e1.wait();
72+
e1.wait();
7373

74-
d_cur = d_head;
75-
for (int i = 0; i < numNodes; i++) {
76-
event c = q.memcpy(&h_cur, d_cur, sizeof(Node));
77-
c.wait();
78-
free(d_cur, ctxt);
74+
d_cur = d_head;
75+
for (int i = 0; i < numNodes; i++) {
76+
event c = q.memcpy(&h_cur, d_cur, sizeof(Node));
77+
c.wait();
78+
free(d_cur, ctxt);
7979

80-
const int want = i * 4 + 1;
81-
if (h_cur.Num != want) {
82-
return -1;
83-
}
84-
d_cur = h_cur.pNext;
80+
const int want = i * 4 + 1;
81+
if (h_cur.Num != want) {
82+
return -2;
8583
}
84+
d_cur = h_cur.pNext;
8685
}
86+
8787
return 0;
8888
}

0 commit comments

Comments
 (0)