Skip to content

Commit 18d6471

Browse files
authored
[SYCL][Fusion][NFC] Remove name and ticket ID from TODOs (#12620)
Remove names of individuals and internal ticket IDs from TODO comments in code.
1 parent e0324da commit 18d6471

File tree

1 file changed

+7
-9
lines changed

1 file changed

+7
-9
lines changed

sycl/source/detail/jit_compiler.cpp

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -667,8 +667,8 @@ jit_compiler::fuseKernels(QueueImplPtr Queue,
667667
unsigned KernelIndex = 0;
668668
ParamList FusedParams;
669669
PromotionMap PromotedAccs;
670-
// TODO(Lukas, ONNX-399): Collect information about streams and auxiliary
671-
// resources (which contain reductions) and figure out how to fuse them.
670+
// TODO: Collect information about streams and auxiliary resources (which
671+
// contain reductions) and figure out how to fuse them.
672672
for (auto &RawCmd : InputKernels) {
673673
auto *KernelCmd = static_cast<ExecCGCommand *>(RawCmd);
674674
auto &CG = KernelCmd->getCG();
@@ -760,8 +760,7 @@ jit_compiler::fuseKernels(QueueImplPtr Queue,
760760
}
761761
}
762762

763-
// TODO(Lukas, ONNX-399): Check for the correct kernel bundle state of the
764-
// device image?
763+
// TODO: Check for the correct kernel bundle state of the device image?
765764
auto &RawDeviceImage = DeviceImage->getRawData();
766765
auto DeviceImageSize = static_cast<size_t>(RawDeviceImage.BinaryEnd -
767766
RawDeviceImage.BinaryStart);
@@ -803,8 +802,7 @@ jit_compiler::fuseKernels(QueueImplPtr Queue,
803802
// Not all overloads of parallel_for_work_group only specify the number of
804803
// work-groups, so the above mechanism might not detect all hierarchical
805804
// parallelism.
806-
// TODO(Lukas, CRD-6): Find a more reliable way to detect hierarchical
807-
// parallelism.
805+
// TODO: Find a more reliable way to detect hierarchical parallelism.
808806
}
809807

810808
// We need to copy the storages here. The input CGs might be eliminated
@@ -815,9 +813,9 @@ jit_compiler::fuseKernels(QueueImplPtr Queue,
815813
KernelCG->getArgsStorage().end());
816814
AccStorage.insert(AccStorage.end(), KernelCG->getAccStorage().begin(),
817815
KernelCG->getAccStorage().end());
818-
// TODO(Lukas, ONNX-399): Does the MSharedPtrStorage contain any
819-
// information about actual shared pointers beside the kernel bundle and
820-
// handler impl? If yes, we might need to copy it here.
816+
// TODO: Does the MSharedPtrStorage contain any information about actual
817+
// shared pointers beside the kernel bundle and handler impl? If yes, we
818+
// might need to copy it here.
821819
Requirements.insert(Requirements.end(), KernelCG->getRequirements().begin(),
822820
KernelCG->getRequirements().end());
823821
Events.insert(Events.end(), KernelCG->getEvents().begin(),

0 commit comments

Comments
 (0)