Skip to content

Commit 1a8c06c

Browse files
[NFC][SYCL] Update comments in sycl/test/abi/sycl_abi_neutrality_test.cpp
1 parent b5dfdc2 commit 1a8c06c

File tree

1 file changed

+16
-2
lines changed

1 file changed

+16
-2
lines changed

sycl/test/abi/sycl_abi_neutrality_test.cpp

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,27 @@
1313
// issue and have to use their ABI-neutral counterparts provided by SYCL RT (e.g
1414
// sycl::detail::string, etc.).
1515

16-
// New exclusions are NOT ALLOWED to this file. All remaining cases that need
17-
// to be fixed are listed below.
16+
// New exclusions are NOT ALLOWED to this file. Some entry points were not fixed
17+
// in time during the last ABI breaking window, so we have to keep providing the
18+
// entry points for them even if newer version of the headers stops using those
19+
// old entry points. Others were exported unnecessarily but only actually used
20+
// inside DSO, yet we have to keep the entry points as well.
21+
22+
// https://github.com/intel/llvm/pull/16179
1823
// CHECK:_ZN4sycl3_V13ext5intel12experimental15online_compilerILNS3_15source_languageE0EE7compileIJSt6vectorINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESaISE_EEEEES8_IhSaIhEERKSE_DpRKT_
1924
// CHECK:_ZN4sycl3_V13ext5intel12experimental15online_compilerILNS3_15source_languageE1EE7compileIJSt6vectorINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESaISE_EEEEES8_IhSaIhEERKSE_DpRKT_
25+
//
26+
// https://github.com/intel/llvm/pull/16178
2027
// CHECK:_ZN4sycl3_V13ext5intel12experimental9pipe_base13get_pipe_nameB5cxx11EPKv
28+
//
29+
// https://github.com/intel/llvm/pull/16177
2130
// CHECK:_ZN4sycl3_V16detail6OSUtil10getDirNameB5cxx11EPKc
2231
// CHECK:_ZN4sycl3_V16detail6OSUtil16getCurrentDSODirB5cxx11Ev
32+
//
33+
// https://github.com/intel/llvm/pull/16176
2334
// CHECK:_ZN4sycl3_V16opencl13has_extensionERKNS0_6deviceERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE
2435
// CHECK:_ZN4sycl3_V16opencl13has_extensionERKNS0_8platformERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE
36+
//
37+
// https://github.com/intel/llvm/pull/15694 and
38+
// https://github.com/intel/llvm/pull/16194
2539
// CHECK:_ZNK4sycl3_V13ext6oneapi12experimental6detail24modifiable_command_graph11print_graphENSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEb

0 commit comments

Comments
 (0)