Skip to content

Commit 1b5361b

Browse files
Avoid copying of NormalizedKernelFunc temporary instance
Coverity analysis of IntelPython/dpctl.git SYCL-based projects shows 6721 hits of COPY_INSTEAD_OF_MOVE type issues in ResetHostKernelHelper with the suggestion to use std::move(NormalizedKernelFunc) instead. This PR applies that suggestion.
1 parent 851b957 commit 1b5361b

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

sycl/include/sycl/handler.hpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -725,9 +725,9 @@ class __SYCL_EXPORT handler {
725725
NormalizedKernelType NormalizedKernel(KernelFunc);
726726
auto NormalizedKernelFunc =
727727
std::function<void(const sycl::nd_item<Dims> &)>(NormalizedKernel);
728-
auto HostKernelPtr =
729-
new detail::HostKernel<decltype(NormalizedKernelFunc),
730-
sycl::nd_item<Dims>, Dims>(NormalizedKernelFunc);
728+
auto HostKernelPtr = new detail::HostKernel<decltype(NormalizedKernelFunc),
729+
sycl::nd_item<Dims>, Dims>(
730+
std::move(NormalizedKernelFunc));
731731
MHostKernel.reset(HostKernelPtr);
732732
return &HostKernelPtr->MKernel.template target<NormalizedKernelType>()
733733
->MKernelFunc;

0 commit comments

Comments
 (0)