Skip to content

Commit 1bacccc

Browse files
Returned the option, but deprecated it
1 parent 6245406 commit 1bacccc

File tree

3 files changed

+11
-1
lines changed

3 files changed

+11
-1
lines changed

clang/include/clang/Driver/Options.td

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4370,6 +4370,10 @@ def fsycl : Flag<["-"], "fsycl">, Flags<[NoXarchOption, CoreOption]>, Group<sycl
43704370
HelpText<"Enables SYCL kernels compilation for device">;
43714371
def fno_sycl : Flag<["-"], "fno-sycl">, Flags<[NoXarchOption, CoreOption]>, Group<sycl_Group>,
43724372
HelpText<"Disables SYCL kernels compilation for device">;
4373+
defm sycl_esimd: BoolFOption<"sycl-explicit-simd",
4374+
LangOpts<"SYCLExplicitSIMD">, DefaultFalse,
4375+
PosFlag<SetTrue, [CC1Option], "Enable">, NegFlag<SetFalse, [], "Disable">,
4376+
BothFlags<[NoArgumentUnused, CoreOption], "SYCL explicit SIMD extension.">>;
43734377
defm sycl_early_optimizations : OptOutFFlag<"sycl-early-optimizations", "Enable", "Disable", " standard optimization pipeline for SYCL device compiler", [CoreOption]>;
43744378
def fsycl_dead_args_optimization : Flag<["-"], "fsycl-dead-args-optimization">,
43754379
Group<sycl_Group>, Flags<[NoArgumentUnused, CoreOption]>, HelpText<"Enables "

clang/lib/Driver/ToolChains/Clang.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5406,7 +5406,9 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA,
54065406
}
54075407

54085408
for (const Arg *A :
5409-
Args.filtered(options::OPT_clang_ignored_legacy_options_Group)) {
5409+
// TODO: remove -fsycl-explicit-simd when support is dropped.
5410+
Args.filtered(options::OPT_clang_ignored_legacy_options_Group,
5411+
options::OPT_fsycl_esimd, options::OPT_fno_sycl_esimd)) {
54105412
D.Diag(diag::warn_ignored_clang_option) << A->getAsString(Args);
54115413
A->claim();
54125414
}

clang/test/Driver/sycl-esimd.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
/// Check that the warning is emmited for using "-fsycl-explicit-simd"
2+
// RUN: %clang -### -fsycl-explicit-simd %s 2>&1 | FileCheck %s
3+
// RUN: %clang -### -fno-sycl-explicit-simd %s 2>&1 | FileCheck %s
4+
// CHECK: the flag '-f{{.*}}sycl-explicit-simd' has been deprecated and will be ignored

0 commit comments

Comments
 (0)