Skip to content

Commit 1c39f3e

Browse files
[SYCL][NFC] Turn on queue::wait unit test with Level Zero (#5226)
The workaround that led to different behavior on Level Zero has been removed.
1 parent f659946 commit 1c39f3e

File tree

1 file changed

+1
-14
lines changed

1 file changed

+1
-14
lines changed

sycl/unittests/queue/Wait.cpp

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -92,14 +92,6 @@ bool preparePiMock(platform &Plt) {
9292
<< std::endl;
9393
return false;
9494
}
95-
// TODO remove once queue:wait() is lowered to PiQueueFinish with level zero
96-
// as well.
97-
if (detail::getSyclObjImpl(Plt)->getPlugin().getBackend() ==
98-
backend::ext_oneapi_level_zero) {
99-
std::cout << "Not run on Level Zero, old behavior is kept there temporarily"
100-
<< std::endl;
101-
return false;
102-
}
10395

10496
unittest::PiMock Mock{Plt};
10597
Mock.redefine<detail::PiApiKind::piQueueCreate>(redefinedQueueCreate);
@@ -129,12 +121,7 @@ TEST(QueueWait, QueueWaitTest) {
129121
TestContext = {};
130122
Q.memset(HostAlloc, 42, 1);
131123
// No need to keep the event since we'll use piQueueFinish.
132-
// FIXME ... unless the plugin is Level Zero, where there's a workaround that
133-
// releases events later.
134-
if (detail::getSyclObjImpl(Plt)->getPlugin().getBackend() !=
135-
backend::ext_oneapi_level_zero) {
136-
ASSERT_EQ(TestContext.EventReferenceCount, 0);
137-
}
124+
ASSERT_EQ(TestContext.EventReferenceCount, 0);
138125
Q.wait();
139126
ASSERT_EQ(TestContext.NEventsWaitedFor, 0);
140127
ASSERT_TRUE(TestContext.PiQueueFinishCalled);

0 commit comments

Comments
 (0)