Skip to content

Commit 21365ca

Browse files
authored
[SYCL][E2E LIT] Remove append_path=True from config.extra_environment handling (#15279)
When append_path is True, value is normalized to lowercase on Windows at https://github.com/llvm-mirror/llvm/blob/2c4ca6832fa6b306ee6a7010bfb80a3f2596f824/utils/lit/lit/llvm/config.py#L139 For env value that isn't a path, the normalization is unexpected. For env value that is a path, it doesn't make sense to append_path unconditionally. Test driver should append path when necessary before setting a env.
1 parent 178a42c commit 21365ca

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

sycl/test-e2e/lit.cfg.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@
122122
for env_pair in config.extra_environment.split(","):
123123
[var, val] = env_pair.split("=", 1)
124124
if val:
125-
llvm_config.with_environment(var, val, append_path=True)
125+
llvm_config.with_environment(var, val)
126126
lit_config.note("\t" + var + "=" + val)
127127
else:
128128
lit_config.note("\tUnset " + var)

0 commit comments

Comments
 (0)