Skip to content

Commit 25a6707

Browse files
author
aidan.belton
committed
make aspect oneapi extension
1 parent b476add commit 25a6707

File tree

8 files changed

+16
-14
lines changed

8 files changed

+16
-14
lines changed

sycl/include/CL/sycl/aspects.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ enum class aspect {
4949
ext_oneapi_native_assert = 31,
5050
host_debuggable = 32,
5151
ext_intel_gpu_hw_threads_per_eu = 33,
52-
bf16 = 34
52+
ext_oneapi_bfloat16 = 34,
5353
};
5454

5555
} // namespace sycl

sycl/include/CL/sycl/info/device_traits.def

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ __SYCL_PARAM_TRAITS_SPEC(device, atomic_memory_order_capabilities,
2727
std::vector<cl::sycl::memory_order>)
2828
__SYCL_PARAM_TRAITS_SPEC(device, atomic_memory_scope_capabilities,
2929
std::vector<cl::sycl::memory_scope>)
30-
__SYCL_PARAM_TRAITS_SPEC(device, bf16, bool)
30+
__SYCL_PARAM_TRAITS_SPEC(device, ext_oneapi_bfloat16, bool)
3131
__SYCL_PARAM_TRAITS_SPEC(device, max_read_image_args, pi_uint32)
3232
__SYCL_PARAM_TRAITS_SPEC(device, max_write_image_args, pi_uint32)
3333
__SYCL_PARAM_TRAITS_SPEC(device, image2d_max_width, size_t)

sycl/include/CL/sycl/info/info_desc.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ enum class device : cl_device_info {
175175
ext_oneapi_max_work_groups_3d = PI_EXT_ONEAPI_DEVICE_INFO_MAX_WORK_GROUPS_3D,
176176
atomic_memory_scope_capabilities =
177177
PI_DEVICE_INFO_ATOMIC_MEMORY_SCOPE_CAPABILITIES,
178-
bf16 = PI_DEVICE_INFO_BF16
178+
ext_oneapi_bfloat16 = PI_EXT_ONEAPI_DEVICE_INFO_BFLOAT16
179179
};
180180

181181
enum class device_type : pi_uint64 {

sycl/plugins/cuda/pi_cuda.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1173,15 +1173,16 @@ pi_result cuda_piDeviceGetInfo(pi_device device, pi_device_info param_name,
11731173
return getInfo(param_value_size, param_value, param_value_size_ret,
11741174
capabilities);
11751175
}
1176-
case PI_DEVICE_INFO_BF16: {
1176+
case PI_EXT_ONEAPI_DEVICE_INFO_BFLOAT16: {
11771177
int major = 0;
11781178
cl::sycl::detail::pi::assertion(
11791179
cuDeviceGetAttribute(&major,
11801180
CU_DEVICE_ATTRIBUTE_COMPUTE_CAPABILITY_MAJOR,
11811181
device->get()) == CUDA_SUCCESS);
11821182

1183-
bool bf16 = (major >= 8) ? true : false;
1184-
return getInfo(param_value_size, param_value, param_value_size_ret, bf16);
1183+
bool bfloat16 = (major >= 8) ? true : false;
1184+
return getInfo(param_value_size, param_value, param_value_size_ret,
1185+
bfloat16);
11851186
}
11861187
case PI_DEVICE_INFO_SUB_GROUP_SIZES_INTEL: {
11871188
// NVIDIA devices only support one sub-group size (the warp size)

sycl/plugins/hip/pi_hip.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1669,7 +1669,7 @@ pi_result hip_piDeviceGetInfo(pi_device device, pi_device_info param_name,
16691669
case PI_DEVICE_INFO_GPU_EU_COUNT_PER_SUBSLICE:
16701670
case PI_DEVICE_INFO_GPU_HW_THREADS_PER_EU:
16711671
case PI_DEVICE_INFO_MAX_MEM_BANDWIDTH:
1672-
case PI_DEVICE_INFO_BF16:
1672+
case PI_EXT_ONEAPI_DEVICE_INFO_BFLOAT16:
16731673
return PI_INVALID_VALUE;
16741674

16751675
default:

sycl/plugins/level_zero/pi_level_zero.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2892,7 +2892,7 @@ pi_result piDeviceGetInfo(pi_device Device, pi_device_info ParamName,
28922892
case PI_DEVICE_INFO_MAX_MEM_BANDWIDTH:
28932893
// currently not supported in level zero runtime
28942894
return PI_INVALID_VALUE;
2895-
case PI_DEVICE_INFO_BF16:
2895+
case PI_EXT_ONEAPI_DEVICE_INFO_BFLOAT16:
28962896
return PI_INVALID_VALUE;
28972897

28982898
// TODO: Implement.

sycl/source/detail/device_impl.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -276,8 +276,8 @@ bool device_impl::has(aspect Aspect) const {
276276
return has_extension("cl_khr_fp16");
277277
case aspect::fp64:
278278
return has_extension("cl_khr_fp64");
279-
case aspect::bf16:
280-
return get_info<info::device::bf16>();
279+
case aspect::ext_oneapi_bfloat16:
280+
return get_info<info::device::ext_oneapi_bfloat16>();
281281
case aspect::int64_base_atomics:
282282
return has_extension("cl_khr_int64_base_atomics");
283283
case aspect::int64_extended_atomics:

sycl/source/detail/device_info.hpp

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -265,14 +265,14 @@ struct get_device_info<std::vector<memory_scope>,
265265
};
266266

267267
// Specialization for bf16
268-
template <> struct get_device_info<bool, info::device::bf16> {
268+
template <> struct get_device_info<bool, info::device::ext_oneapi_bfloat16> {
269269
static bool get(RT::PiDevice dev, const plugin &Plugin) {
270270

271271
bool result = false;
272272

273273
RT::PiResult Err = Plugin.call_nocheck<PiApiKind::piDeviceGetInfo>(
274-
dev, pi::cast<RT::PiDeviceInfo>(info::device::bf16), sizeof(result),
275-
&result, nullptr);
274+
dev, pi::cast<RT::PiDeviceInfo>(info::device::ext_oneapi_bfloat16),
275+
sizeof(result), &result, nullptr);
276276
if (Err != PI_SUCCESS) {
277277
return false;
278278
}
@@ -785,7 +785,8 @@ get_device_info_host<info::device::atomic_memory_scope_capabilities>() {
785785
memory_scope::work_group, memory_scope::device, memory_scope::system};
786786
}
787787

788-
template <> inline bool get_device_info_host<info::device::bf16>() {
788+
template <>
789+
inline bool get_device_info_host<info::device::ext_oneapi_bfloat16>() {
789790
return false;
790791
}
791792

0 commit comments

Comments
 (0)