Skip to content

Commit 263dafb

Browse files
committed
Use vars for libclc target names
1 parent 0281c05 commit 263dafb

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

buildbot/configure.py

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@ def do_configure(args):
1515

1616
llvm_external_projects = 'sycl;llvm-spirv;opencl;libdevice;xpti;xptifw'
1717

18+
libclc_amd_target_names = ';amdgcn--;amdgcn--amdhsa'
19+
libclc_nvidia_target_names = 'nvptx64--;nvptx64--nvidiacl'
20+
1821
if args.llvm_external_projects:
1922
llvm_external_projects += ";" + args.llvm_external_projects.replace(",", ";")
2023

@@ -55,22 +58,22 @@ def do_configure(args):
5558

5659
if args.cuda:
5760
llvm_targets_to_build += ';NVPTX'
58-
libclc_targets_to_build = 'nvptx64--;nvptx64--nvidiacl'
61+
libclc_targets_to_build = libclc_nvidia_target_names
5962
libclc_gen_remangled_variants = 'ON'
6063
sycl_build_pi_cuda = 'ON'
6164

6265
if args.hip:
6366
if args.hip_platform == 'AMD':
6467
llvm_targets_to_build += ';AMDGPU'
65-
libclc_targets_to_build += ';amdgcn--;amdgcn--amdhsa'
68+
libclc_targets_to_build += libclc_amd_target_names
6669
if args.hip_amd_arch:
6770
sycl_clang_extra_flags += "-Xsycl-target-backend=amdgcn-amd-amdhsa --offload-arch="+args.hip_amd_arch
6871

6972
# The HIP plugin for AMD uses lld for linking
7073
llvm_enable_projects += ';lld'
7174
elif args.hip_platform == 'NVIDIA' and not args.cuda:
7275
llvm_targets_to_build += ';NVPTX'
73-
libclc_targets_to_build += ';nvptx64--;nvptx64--nvidiacl'
76+
libclc_targets_to_build += libclc_nvidia_target_names
7477
libclc_gen_remangled_variants = 'ON'
7578

7679
sycl_build_pi_hip_platform = args.hip_platform
@@ -109,10 +112,10 @@ def do_configure(args):
109112
if 'NVPTX' not in llvm_targets_to_build:
110113
llvm_targets_to_build += ';NVPTX'
111114
# Add both NVIDIA and AMD libclc targets
112-
if 'amdgcn--;amdgcn--amdhsa' not in libclc_targets_to_build:
113-
libclc_targets_to_build += ';amdgcn--;amdgcn--amdhsa'
114-
if 'nvptx64--;nvptx64--nvidiacl' not in libclc_targets_to_build:
115-
libclc_targets_to_build += ';nvptx64--;nvptx64--nvidiacl'
115+
if libclc_amd_target_names not in libclc_targets_to_build:
116+
libclc_targets_to_build += libclc_amd_target_names
117+
if libclc_nvidia_target_names not in libclc_targets_to_build:
118+
libclc_targets_to_build += libclc_nvidia_target_names
116119

117120
install_dir = os.path.join(abs_obj_dir, "install")
118121

0 commit comments

Comments
 (0)