Skip to content

Commit 26619e0

Browse files
author
Pavel Chupin
authored
[SYCL] Update ABI check for Ubuntu 22 differences (#7446)
__libc_csu_init and __libc_csu_fini are not included anymore in the binary. See more detailed comment inlined.
1 parent b1533c5 commit 26619e0

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed
Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
__libc_csu_fini
2-
__libc_csu_init
31
_start
42
_Z3foov
53
main

sycl/tools/abi_check.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,13 @@ def parse_readobj_output(output):
5656
# is used. Ignore it for the purpose of the library ABI check.
5757
ignore_symbols = ["_dl_relocate_static_pie"]
5858

59+
# Starting from glibc 2.34 these symbols are not present anymore in the binary
60+
# Ignoring these in case older glibc is used.
61+
# Note that Ubuntu 20 has glibc 2.31 and Ubuntu 22 has glibc 2.35
62+
# See: https://github.com/bminor/glibc/commit/035c012e32c11e84d64905efaf55e74f704d3668
63+
ignore_symbols += ["__libc_csu_fini",
64+
"__libc_csu_init"]
65+
5966
# In some scenarios MSVC and clang-cl exhibit differences in regards to the exported symbols they generate.
6067
# Some of them happen in the SYCL RT library and we think clang-cl's behavior is more reasonable.
6168
#

0 commit comments

Comments
 (0)