Skip to content

Commit 2713910

Browse files
[NFC][SYCL] Add/Remove punctuation (#4830)
Change diagnostic punctuation to be consistent with Clang diagnostics Signed-off-by: Elizabeth Andrews <[email protected]>
1 parent f69380f commit 2713910

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

clang/include/clang/Basic/DiagnosticDriverKinds.td

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,8 @@ def warn_drv_partially_supported_cuda_version: Warning<
9191
def err_drv_cuda_host_arch : Error<
9292
"unsupported architecture '%0' for host compilation">;
9393
def err_drv_no_sycl_libspirv : Error<
94-
"cannot find '%0'; provide path to libspirv library via '-fsycl-libspirv-path' or "
95-
"pass '-fno-sycl-libspirv' to build without linking with libspirv.">;
94+
"cannot find '%0'; provide path to libspirv library via '-fsycl-libspirv-path', or "
95+
"pass '-fno-sycl-libspirv' to build without linking with libspirv">;
9696
def err_drv_mix_cuda_hip : Error<
9797
"mixed CUDA and HIP compilation is not supported">;
9898
def err_drv_bad_target_id : Error<

clang/test/Driver/sycl-libspirv-invalid.cpp

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,19 +6,22 @@
66
// RUN: -fsycl-targets=nvptx64-nvidia-cuda --cuda-path=%S/Inputs/CUDA/usr/local/cuda \
77
// RUN: -fsycl-libspirv-path=%S/Inputs/SYCL/no-libspirv-exists-here.bc %s 2>&1 \
88
// RUN: | FileCheck --check-prefix=ERR-CUDA %s
9-
// ERR-CUDA: cannot find 'remangled-l64-signed_char.libspirv-nvptx64--nvidiacl.bc'
9+
// ERR-CUDA: cannot find 'remangled-l64-signed_char.libspirv-nvptx64--nvidiacl.bc';
10+
// ERR-CUDA-SAME: provide path to libspirv library via '-fsycl-libspirv-path', or pass '-fno-sycl-libspirv' to build without linking with libspirv
1011

1112
// RUN: %clangxx -### -std=c++11 -target x86_64-unknown-windows-msvc -fsycl \
1213
// RUN: -fsycl-targets=nvptx64-nvidia-cuda --cuda-path=%S/Inputs/CUDA/usr/local/cuda \
1314
// RUN: -fsycl-libspirv-path=%S/Inputs/SYCL/no-libspirv-exists-here.bc %s 2>&1 \
1415
// RUN: | FileCheck --check-prefix=ERR-CUDA-WIN %s
15-
// ERR-CUDA-WIN: cannot find 'remangled-l32-signed_char.libspirv-nvptx64--nvidiacl.bc'
16+
// ERR-CUDA-WIN: cannot find 'remangled-l32-signed_char.libspirv-nvptx64--nvidiacl.bc';
17+
// ERR-CUDA-WIN-SAME: provide path to libspirv library via '-fsycl-libspirv-path', or pass '-fno-sycl-libspirv' to build without linking with libspirv
1618

1719
// RUN: %clangxx -### -std=c++11 -target x86_64-unknown-linux-gnu -fsycl \
1820
// RUN: -fsycl-targets=amdgcn-amd-amdhsa -Xsycl-target-backend --offload-arch=gfx908 \
1921
// RUN: -fsycl-libspirv-path=%S/Inputs/SYCL/no-libspirv-exists-here.bc %s 2>&1 \
2022
// RUN: | FileCheck --check-prefix=ERR-HIP %s
21-
// ERR-HIP: cannot find 'remangled-l64-signed_char.libspirv-amdgcn--amdhsa.bc'
23+
// ERR-HIP: cannot find 'remangled-l64-signed_char.libspirv-amdgcn--amdhsa.bc';
24+
// ERR-HIP-SAME: provide path to libspirv library via '-fsycl-libspirv-path', or pass '-fno-sycl-libspirv' to build without linking with libspirv
2225

2326
// RUN: %clangxx -### -std=c++11 -target x86_64-unknown-linux-gnu -fsycl \
2427
// RUN: -fsycl-targets=nvptx64-nvidia-cuda --cuda-path=%S/Inputs/CUDA/usr/local/cuda \

0 commit comments

Comments
 (0)