addressed review comments

Author: t4c1

sycl/include/CL/sycl/detail/pi.h

@@ -441,16 +441,16 @@ typedef enum {
 typedef enum {
   // Device-specific value opaque in PI API.
   PI_MEM_ADVISE_UNKNOWN,
-  PI_MEM_ADVISE_CUDA_SET_READ_MOSTLY = 1,
-  PI_MEM_ADVISE_CUDA_UNSET_READ_MOSTLY = 2,
-  PI_MEM_ADVISE_CUDA_SET_PREFERRED_LOCATION = 3,
-  PI_MEM_ADVISE_CUDA_UNSET_PREFERRED_LOCATION = 4,
-  PI_MEM_ADVISE_CUDA_SET_ACCESSED_BY = 5,
-  PI_MEM_ADVISE_CUDA_UNSET_ACCESSED_BY = 6,
-  PI_MEM_ADVISE_CUDA_SET_PREFERRED_LOCATION_HOST = 7,
-  PI_MEM_ADVISE_CUDA_UNSET_PREFERRED_LOCATION_HOST = 8,
-  PI_MEM_ADVISE_CUDA_SET_ACCESSED_BY_HOST = 9,
-  PI_MEM_ADVISE_CUDA_UNSET_ACCESSED_BY_HOST = 10,
+  PI_MEM_ADVISE_CUDA_SET_READ_MOSTLY = 101,
+  PI_MEM_ADVISE_CUDA_UNSET_READ_MOSTLY = 102,
+  PI_MEM_ADVISE_CUDA_SET_PREFERRED_LOCATION = 103,
+  PI_MEM_ADVISE_CUDA_UNSET_PREFERRED_LOCATION = 104,
+  PI_MEM_ADVISE_CUDA_SET_ACCESSED_BY = 105,
+  PI_MEM_ADVISE_CUDA_UNSET_ACCESSED_BY = 106,
+  PI_MEM_ADVISE_CUDA_SET_PREFERRED_LOCATION_HOST = 107,
+  PI_MEM_ADVISE_CUDA_UNSET_PREFERRED_LOCATION_HOST = 108,
+  PI_MEM_ADVISE_CUDA_SET_ACCESSED_BY_HOST = 109,
+  PI_MEM_ADVISE_CUDA_UNSET_ACCESSED_BY_HOST = 110,
 } _pi_mem_advice;
 
 typedef enum {

sycl/plugins/cuda/pi_cuda.cpp

@@ -4717,7 +4717,10 @@ pi_result cuda_piextUSMEnqueueMemAdvise(pi_queue queue, const void *ptr,
     case PI_MEM_ADVISE_CUDA_SET_ACCESSED_BY:
     case PI_MEM_ADVISE_CUDA_UNSET_ACCESSED_BY:
       result = PI_CHECK_ERROR(
-          cuMemAdvise((CUdeviceptr)ptr, length, (CUmem_advise)advice,
+          cuMemAdvise((CUdeviceptr)ptr, 
+                      length, 
+                      (CUmem_advise)(
+                        advice - PI_MEM_ADVISE_CUDA_SET_READ_MOSTLY + 1),
                       queue->get_context()->get_device()->get()));
       break;
     case PI_MEM_ADVISE_CUDA_SET_PREFERRED_LOCATION_HOST:
@@ -4726,10 +4729,10 @@ pi_result cuda_piextUSMEnqueueMemAdvise(pi_queue queue, const void *ptr,
     case PI_MEM_ADVISE_CUDA_UNSET_ACCESSED_BY_HOST:
       result = PI_CHECK_ERROR(cuMemAdvise(
           (CUdeviceptr)ptr, length,
-          (CUmem_advise)(advice -
+          (CUmem_advise)(advice - PI_MEM_ADVISE_CUDA_SET_READ_MOSTLY + 1 -
                          (PI_MEM_ADVISE_CUDA_SET_PREFERRED_LOCATION_HOST -
                           PI_MEM_ADVISE_CUDA_SET_PREFERRED_LOCATION)),
-          -1));
+          CU_DEVICE_CPU));
       break;
     default:
       cl::sycl::detail::pi::die("Unknown advice");