[SYCL][E2E] Fix max color value in image test (#10064)

This commit fixes an issue where the maximum value for a new color in
the image write tests would cause a conversion to an invalid value,
which in turn would cause written and read values to differ.

Signed-off-by: Larsen, Steffen <[email protected]>

Author: steffenlarsen

sycl/test-e2e/Basic/sycl_2020_images/common.hpp

@@ -329,20 +329,18 @@ ApplyAddressingMode(CoordT<ImageType::Sampled, Dims> Coord,
   }
 }
 
-template <image_format Format> static constexpr size_t getMaxInt() {
-  using rep_elem_type = typename FormatTraits<Format>::rep_elem_type;
-  return static_cast<size_t>(std::numeric_limits<rep_elem_type>::max());
-}
-
 template <image_format Format>
 typename FormatTraits<Format>::pixel_type PickNewColor(size_t I,
                                                        size_t AccSize) {
+  using RepElemT = typename FormatTraits<Format>::rep_elem_type;
   using PixelType = typename FormatTraits<Format>::pixel_type;
+
   size_t Idx = I * 4;
 
   // Pick a new color. Make sure it isn't too big for the data type.
   PixelType NewColor{Idx, Idx + 1, Idx + 2, Idx + 3};
-  NewColor = sycl::min(NewColor, PixelType{getMaxInt<Format>()});
+  PixelType MaxPixelVal{std::numeric_limits<RepElemT>::max()};
+  NewColor = sycl::min(NewColor, MaxPixelVal);
   if constexpr (FormatTraits<Format>::Normalized)
     NewColor /= AccSize * 4;
   return NewColor;