Skip to content

Commit 2ba98e5

Browse files
committed
Apply comments
1 parent 46ed826 commit 2ba98e5

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

sycl/include/sycl/detail/vector_convert.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -541,7 +541,7 @@ NativeToT convertImpl(NativeFromT Value) {
541541
// what to do here. 'static_cast' implementation matches SYCL CTS and it
542542
// matches our old implementation. Unfortunately, OpSetConvertUToS and
543543
// OpSatConvertSToU behave differently and we can't use them here until the
544-
// behavior of conversions is well-defined by the SYCL 2020 speficiation.
544+
// behavior of conversions is well-defined by the SYCL 2020 specificiation.
545545
// See https://github.com/KhronosGroup/SYCL-Docs/issues/492
546546
return static_cast<NativeToT>(Value);
547547
}

sycl/test-e2e/Basic/vector/int-convert.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,7 @@ template <typename From, typename To> void check_signed_unsigned_convert_to() {
116116

117117
template <typename From> void check_convert_from() {
118118
check_signed_unsigned_convert_to<From, sycl::byte>();
119+
// FIXME: enable test cases below once compilation issues for them are fixed
119120
// check_signed_unsigned_convert_to<From, std::byte>();
120121
check_signed_unsigned_convert_to<From, std::int8_t>();
121122
check_signed_unsigned_convert_to<From, std::int16_t>();

0 commit comments

Comments
 (0)