Skip to content

Commit 2e396bd

Browse files
[SYCL] Delay inclusion of sycl/types.hpp in core.hpp
Can't eliminate it completely until #13760 is merged, but this PR brings us closer to that goal.
1 parent f739a6d commit 2e396bd

File tree

5 files changed

+10
-9
lines changed

5 files changed

+10
-9
lines changed

sycl/include/sycl/ext/intel/experimental/task_sequence.hpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010

1111
#include <CL/__spirv/spirv_ops.hpp>
1212
#include <CL/__spirv/spirv_types.hpp>
13+
#include <sycl/aspects.hpp>
1314
#include <sycl/exception.hpp>
1415
#include <sycl/ext/intel/experimental/fpga_kernel_properties.hpp>
1516
#include <sycl/ext/intel/experimental/task_sequence_properties.hpp>

sycl/include/sycl/ext/oneapi/experimental/prefetch.hpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010

1111
#include <CL/__spirv/spirv_ops.hpp>
1212
#include <sycl/ext/oneapi/properties/properties.hpp>
13+
#include <sycl/types.hpp>
1314

1415
namespace sycl {
1516
inline namespace _V1 {

sycl/include/sycl/ext/oneapi/properties/properties.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@
88

99
#pragma once
1010

11+
#include <sycl/detail/is_device_copyable.hpp>
1112
#include <sycl/ext/oneapi/properties/property.hpp> // for IsRuntimePr...
1213
#include <sycl/ext/oneapi/properties/property_utils.hpp> // for Sorted, Mer...
1314
#include <sycl/ext/oneapi/properties/property_value.hpp> // for property_value
14-
#include <sycl/types.hpp> // for is_device_c...
1515

1616
#include <tuple> // for tuple, tupl...
1717
#include <type_traits> // for enable_if_t

sycl/include/sycl/sub_group.hpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
#include <sycl/memory_enums.hpp> // for memory_scope
1919
#include <sycl/multi_ptr.hpp> // for multi_ptr
2020
#include <sycl/range.hpp> // for range
21-
#include <sycl/types.hpp> // for vec
2221

2322
#ifdef __SYCL_DEVICE_ONLY__
2423
#include <sycl/ext/oneapi/functional.hpp>
@@ -33,7 +32,7 @@ inline namespace _V1 {
3332
template <typename T, access::address_space Space,
3433
access::decorated DecorateAddress>
3534
class multi_ptr;
36-
35+
template <typename Type, int NumElements> class vec;
3736
namespace detail {
3837

3938
namespace sub_group {

sycl/test/include_deps/sycl_detail_core.hpp.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -133,12 +133,6 @@
133133
// CHECK-NEXT: nd_item.hpp
134134
// CHECK-NEXT: nd_range.hpp
135135
// CHECK-NEXT: sub_group.hpp
136-
// CHECK-NEXT: types.hpp
137-
// CHECK-NEXT: marray.hpp
138-
// CHECK-NEXT: vector.hpp
139-
// CHECK-NEXT: detail/memcpy.hpp
140-
// CHECK-NEXT: detail/vector_convert.hpp
141-
// CHECK-NEXT: swizzles.def
142136
// CHECK-NEXT: ext/oneapi/functional.hpp
143137
// CHECK-NEXT: detail/spirv.hpp
144138
// CHECK-NEXT: ext/oneapi/experimental/non_uniform_groups.hpp
@@ -148,6 +142,12 @@
148142
// CHECK-NEXT: builtins_utils_vec.hpp
149143
// CHECK-NEXT: builtins_utils_scalar.hpp
150144
// CHECK-NEXT: detail/boolean.hpp
145+
// CHECK-NEXT: marray.hpp
146+
// CHECK-NEXT: types.hpp
147+
// CHECK-NEXT: vector.hpp
148+
// CHECK-NEXT: detail/memcpy.hpp
149+
// CHECK-NEXT: detail/vector_convert.hpp
150+
// CHECK-NEXT: swizzles.def
151151
// CHECK-NEXT: detail/builtins/common_functions.inc
152152
// CHECK-NEXT: detail/builtins/helper_macros.hpp
153153
// CHECK-NEXT: detail/builtins/geometric_functions.inc

0 commit comments

Comments
 (0)