Apply suggestions from code review

kbobrovs · v-klochkov · web-flow · commit 34ee62894a79 · 2022-01-11T12:05:52.000-08:00
Co-authored-by: Vyacheslav Klochkov &lt;vyacheslav.n.klochkov@intel.com&gt;
diff --git a/sycl/include/sycl/ext/intel/experimental/esimd/detail/math_intrin.hpp b/sycl/include/sycl/ext/intel/experimental/esimd/detail/math_intrin.hpp
@@ -262,7 +262,7 @@ __ESIMD_INTRIN __ESIMD_raw_vec_t(T, N)
         ;
 #else
 {
-  if (__SEIEED::is_wrapper_elem_type_v<T>)
+  if constexpr (__SEIEED::is_wrapper_elem_type_v<T>)
     __ESIMD_UNSUPPORTED_ON_HOST;
   __ESIMD_raw_vec_t(T, N) retv;
   for (auto i = 0; i != N; i += 4) {
diff --git a/sycl/include/sycl/ext/intel/experimental/esimd/math.hpp b/sycl/include/sycl/ext/intel/experimental/esimd/math.hpp
@@ -1643,8 +1643,8 @@ ESIMD_NODEBUG ESIMD_INLINE simd<T, SZ> log(simd<T, SZ> src0) {
 
   if constexpr (Flag != saturation_on)
     return Result;
-
-  return esimd::saturate<T>(Result);
+  else
+    return esimd::saturate<T>(Result);
 }
 
 template <class T> ESIMD_NODEBUG ESIMD_INLINE T log(T src0, int flag) {

Original file line number	Diff line number	Diff line change
`@@ -262,7 +262,7 @@ __ESIMD_INTRIN __ESIMD_raw_vec_t(T, N)`
`262`	`262`	`;`
`263`	`263`	`#else`
`264`	`264`	`{`
`265`		`- if (__SEIEED::is_wrapper_elem_type_v<T>)`
	`265`	`+ if constexpr (__SEIEED::is_wrapper_elem_type_v<T>)`
`266`	`266`	`__ESIMD_UNSUPPORTED_ON_HOST;`
`267`	`267`	`__ESIMD_raw_vec_t(T, N) retv;`
`268`	`268`	`for (auto i = 0; i != N; i += 4) {`
Original file line number	Diff line number	Diff line change
`@@ -1643,8 +1643,8 @@ ESIMD_NODEBUG ESIMD_INLINE simd<T, SZ> log(simd<T, SZ> src0) {`
`1643`	`1643`
`1644`	`1644`	`if constexpr (Flag != saturation_on)`
`1645`	`1645`	`return Result;`
`1646`		`-`
`1647`		`- return esimd::saturate<T>(Result);`
	`1646`	`+ else`
	`1647`	`+ return esimd::saturate<T>(Result);`
`1648`	`1648`	`}`
`1649`	`1649`
`1650`	`1650`	`template <class T> ESIMD_NODEBUG ESIMD_INLINE T log(T src0, int flag) {`