Skip to content

Commit 35f866a

Browse files
committed
Minor editorial changes
Fix spelling mistakes, make formatting consistent, etc.
1 parent 105ff57 commit 35f866a

File tree

1 file changed

+8
-10
lines changed

1 file changed

+8
-10
lines changed

sycl/doc/OptionalDeviceFeatures.md

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -524,30 +524,28 @@ x86_64_avx512:
524524
```
525525

526526
The values of the aspects in this configuration file can be the numerical
527-
values from the `enum class aspect` enumeration or the enum identifer itself.
527+
values from the `enum class aspect` enumeration or the enum identifier itself.
528528
For each valid AOT compiler ID the driver has a built-in rule how to construct
529529
an AOT compilation command line based on given architecture name. For example,
530530
for the `gen11_1` and `gen_icl` architectures, the driver sees `gen-spir64`
531531
as the AOT compiler ID, so it knows that the `ocloc` tool must be used, and it
532532
also knows how to translate the `gen11_1` or `gen_icl` to proper `ocloc`
533533
architecture specification option.
534534

535-
*NOTE: new kinds of AOT compilers are expected to appear very rarely, so
535+
**NOTE**: New kinds of AOT compilers are expected to appear very rarely, so
536536
developing some kind of "AOT compiler plugin" mechanism is impractical, and
537-
hardcoding AOT compiler types in the driver is resonable.*
537+
hard coding AOT compiler types in the driver is reasonable.
538538

539539
One advantage to encoding this information in a textual configuration file is
540540
that customers can update the file if necessary. This could be useful, for
541541
example, if a new device is released before there is a new DPC++ release. In
542542
fact, the DPC++ driver supports a command line option which allows the user
543543
to select an alternate configuration file.
544544

545-
**TODO**: Add more sections here describing the changes to the DPC++ driver
546-
and related tools. Other things to describe are:
545+
**TODO**: More information will be inserted here when we merge
546+
[this separate PR][6] into this design document.
547547

548-
* The names of the devices in the configuration file.
549-
* The name of the DPC++ driver option that selects an alternate configuration
550-
file.
548+
[6]: <https://github.com/gmlueck/llvm/pull/1>
551549

552550
### Changes to the DPC++ runtime
553551

@@ -612,15 +610,15 @@ have information about source location of "used" aspects.
612610

613611
## Appendix: Adding an attribute to 8-byte `atomic_ref`
614612

615-
As described above under ["Changes to DPC++ headers"][6], we need to decorate
613+
As described above under ["Changes to DPC++ headers"][7], we need to decorate
616614
any SYCL type representing an optional device feature with the
617615
`[[sycl_detail::uses_aspects()]]` attribute. This is somewhat tricky for
618616
`atomic_ref`, though, because it is only an optional feature when specialized
619617
for a 8-byte type. However, we can accomplish this by using partial
620618
specialization techniques. The following code snippet demonstrates (best read
621619
from bottom to top):
622620

623-
[6]: <#changes-to-dpc-headers>
621+
[7]: <#changes-to-dpc-headers>
624622

625623
```
626624
namespace sycl {

0 commit comments

Comments
 (0)