@@ -524,30 +524,28 @@ x86_64_avx512:
524
524
```
525
525
526
526
The values of the aspects in this configuration file can be the numerical
527
- values from the ` enum class aspect ` enumeration or the enum identifer itself.
527
+ values from the ` enum class aspect ` enumeration or the enum identifier itself.
528
528
For each valid AOT compiler ID the driver has a built-in rule how to construct
529
529
an AOT compilation command line based on given architecture name. For example,
530
530
for the ` gen11_1 ` and ` gen_icl ` architectures, the driver sees ` gen-spir64 `
531
531
as the AOT compiler ID, so it knows that the ` ocloc ` tool must be used, and it
532
532
also knows how to translate the ` gen11_1 ` or ` gen_icl ` to proper ` ocloc `
533
533
architecture specification option.
534
534
535
- * NOTE: new kinds of AOT compilers are expected to appear very rarely, so
535
+ ** NOTE** : New kinds of AOT compilers are expected to appear very rarely, so
536
536
developing some kind of "AOT compiler plugin" mechanism is impractical, and
537
- hardcoding AOT compiler types in the driver is resonable. *
537
+ hard coding AOT compiler types in the driver is reasonable.
538
538
539
539
One advantage to encoding this information in a textual configuration file is
540
540
that customers can update the file if necessary. This could be useful, for
541
541
example, if a new device is released before there is a new DPC++ release. In
542
542
fact, the DPC++ driver supports a command line option which allows the user
543
543
to select an alternate configuration file.
544
544
545
- ** TODO** : Add more sections here describing the changes to the DPC++ driver
546
- and related tools. Other things to describe are:
545
+ ** TODO** : More information will be inserted here when we merge
546
+ [ this separate PR ] [ 6 ] into this design document.
547
547
548
- * The names of the devices in the configuration file.
549
- * The name of the DPC++ driver option that selects an alternate configuration
550
- file.
548
+ [ 6 ] : < https://github.com/gmlueck/llvm/pull/1 >
551
549
552
550
### Changes to the DPC++ runtime
553
551
@@ -612,15 +610,15 @@ have information about source location of "used" aspects.
612
610
613
611
## Appendix: Adding an attribute to 8-byte ` atomic_ref `
614
612
615
- As described above under [ "Changes to DPC++ headers"] [ 6 ] , we need to decorate
613
+ As described above under [ "Changes to DPC++ headers"] [ 7 ] , we need to decorate
616
614
any SYCL type representing an optional device feature with the
617
615
` [[sycl_detail::uses_aspects()]] ` attribute. This is somewhat tricky for
618
616
` atomic_ref ` , though, because it is only an optional feature when specialized
619
617
for a 8-byte type. However, we can accomplish this by using partial
620
618
specialization techniques. The following code snippet demonstrates (best read
621
619
from bottom to top):
622
620
623
- [ 6 ] : < #changes-to-dpc-headers >
621
+ [ 7 ] : < #changes-to-dpc-headers >
624
622
625
623
```
626
624
namespace sycl {
0 commit comments