[SYCL] piextQueueCreateWithNativeHandle should not be followed by a piQueueRetain

smaslov-intel · smaslov-intel · commit 3690165af6ee · 2021-11-18T12:40:44.000-08:00
Signed-off-by: Sergey V Maslov &lt;sergey.v.maslov@intel.com&gt;
diff --git a/sycl/plugins/opencl/pi_opencl.cpp b/sycl/plugins/opencl/pi_opencl.cpp
@@ -389,6 +389,7 @@ pi_result piextQueueCreateWithNativeHandle(pi_native_handle nativeHandle,
   (void)ownNativeHandle;
   assert(piQueue != nullptr);
   *piQueue = reinterpret_cast<pi_queue>(nativeHandle);
+  clRetainCommandQueue(*piQueue);
   return PI_SUCCESS;
 }
 
diff --git a/sycl/source/detail/queue_impl.hpp b/sycl/source/detail/queue_impl.hpp
@@ -129,9 +129,6 @@ class queue_impl {
                                            sizeof(Device), &Device, nullptr);
     MDevice =
         DeviceImplPtr(new device_impl(Device, Context->getPlatformImpl()));
-
-    // TODO catch an exception and put it to list of asynchronous exceptions
-    getPlugin().call<PiApiKind::piQueueRetain>(MQueues[0]);
   }
 
   ~queue_impl() {

Original file line number	Diff line number	Diff line change
`@@ -389,6 +389,7 @@ pi_result piextQueueCreateWithNativeHandle(pi_native_handle nativeHandle,`
`389`	`389`	`(void)ownNativeHandle;`
`390`	`390`	`assert(piQueue != nullptr);`
`391`	`391`	`*piQueue = reinterpret_cast<pi_queue>(nativeHandle);`
	`392`	`+ clRetainCommandQueue(*piQueue);`
`392`	`393`	`return PI_SUCCESS;`
`393`	`394`	`}`
`394`	`395`
Original file line number	Diff line number	Diff line change
`@@ -129,9 +129,6 @@ class queue_impl {`
`129`	`129`	`sizeof(Device), &Device, nullptr);`
`130`	`130`	`MDevice =`
`131`	`131`	`DeviceImplPtr(new device_impl(Device, Context->getPlatformImpl()));`
`132`		`-`
`133`		`- // TODO catch an exception and put it to list of asynchronous exceptions`
`134`		`- getPlugin().call<PiApiKind::piQueueRetain>(MQueues[0]);`
`135`	`132`	`}`
`136`	`133`
`137`	`134`	`~queue_impl() {`