Skip to content

Commit 36c61d7

Browse files
[SYCL][ESIMD] Preserve undef initializer for globals in ESIMDLowerVecArg pass (#2555)
1 parent b84d49b commit 36c61d7

File tree

2 files changed

+28
-3
lines changed

2 files changed

+28
-3
lines changed

llvm/lib/SYCLLowerIR/LowerESIMDVecArg.cpp

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -272,10 +272,13 @@ void ESIMDLowerVecArgPass::fixGlobals(Module &M) {
272272
if (NewTy && !G.user_empty()) {
273273
// Peel off ptr type that getSimdArgPtrTyOrNull applies
274274
NewTy = NewTy->getPointerElementType();
275-
auto ZeroInit = ConstantAggregateZero::get(NewTy);
275+
auto InitVal =
276+
G.hasInitializer() && isa<UndefValue>(G.getInitializer())
277+
? static_cast<ConstantData *>(UndefValue::get(NewTy))
278+
: static_cast<ConstantData *>(ConstantAggregateZero::get(NewTy));
276279
auto NewGlobalVar =
277-
new GlobalVariable(NewTy, G.isConstant(), G.getLinkage(), ZeroInit,
278-
"", G.getThreadLocalMode(), G.getAddressSpace());
280+
new GlobalVariable(NewTy, G.isConstant(), G.getLinkage(), InitVal, "",
281+
G.getThreadLocalMode(), G.getAddressSpace());
279282
NewGlobalVar->setExternallyInitialized(G.isExternallyInitialized());
280283
NewGlobalVar->copyAttributesFrom(&G);
281284
NewGlobalVar->takeName(&G);
Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
2+
; RUN: opt < %s -ESIMDLowerVecArg -S | FileCheck %s
3+
4+
; This test checks that undef initializer of a global variable is preserved
5+
; during ESIMDLowerVecArg transformation
6+
7+
target datalayout = "e-i64:64-v16:16-v24:32-v32:32-v48:64-v96:128-v192:256-v256:256-v512:512-v1024:1024-n8:16:32:64"
8+
target triple = "spir64-unknown-unknown-sycldevice"
9+
10+
%"class.cl::sycl::INTEL::gpu::simd" = type { <2512 x i32> }
11+
12+
; CHECK: @Global = dso_local global <2512 x i32> undef, align 16384
13+
@Global = dso_local global %"class.cl::sycl::INTEL::gpu::simd" undef, align 16384
14+
15+
define void @f(<2512 x i32> %simd_val) {
16+
; CHECK-LABEL: @f(
17+
; CHECK-NEXT: store <2512 x i32> [[SIMD_VAL:%.*]], <2512 x i32> addrspace(4)* getelementptr (%"class.cl::sycl::INTEL::gpu::simd", %"class.cl::sycl::INTEL::gpu::simd" addrspace(4)* addrspacecast (%"class.cl::sycl::INTEL::gpu::simd"* bitcast (<2512 x i32>* @Global to %"class.cl::sycl::INTEL::gpu::simd"*) to %"class.cl::sycl::INTEL::gpu::simd" addrspace(4)*), i64 0, i32 0), align 16384
18+
; CHECK-NEXT: ret void
19+
;
20+
store <2512 x i32> %simd_val, <2512 x i32> addrspace(4)* getelementptr (%"class.cl::sycl::INTEL::gpu::simd", %"class.cl::sycl::INTEL::gpu::simd" addrspace(4)* addrspacecast (%"class.cl::sycl::INTEL::gpu::simd"* @Global to %"class.cl::sycl::INTEL::gpu::simd" addrspace(4)*), i64 0, i32 0), align 16384
21+
ret void
22+
}

0 commit comments

Comments
 (0)