Skip to content

Commit 3758172

Browse files
authored
[SYCL][E2E][JM] Enable tests passing on PVC (#17932)
The other change related to increasing the sizes is due to the fact that stride has to be > 64 bytes in order for 2d block read/write is correctly generated.
1 parent 3543603 commit 3758172

6 files changed

+7
-10
lines changed

sycl/test-e2e/Matrix/Inputs/joint_matrix_int8_colmajorA_colmajorB_impl.hpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,9 +77,9 @@ void matrix_multiply(big_matrix<T1, NUM_ROWS_C, NUM_COLS_C> &C,
7777
}
7878

7979
int main() {
80-
static constexpr size_t MATRIX_M = TM;
81-
static constexpr size_t MATRIX_N = TN;
82-
static constexpr size_t MATRIX_K = TK;
80+
static constexpr size_t MATRIX_M = TM * 8;
81+
static constexpr size_t MATRIX_N = TN * 4;
82+
static constexpr size_t MATRIX_K = TK * 4;
8383
int8_t A[MATRIX_K][MATRIX_M];
8484
int8_t Aref[MATRIX_K][MATRIX_M];
8585
int8_t B[MATRIX_N][MATRIX_K];

sycl/test-e2e/Matrix/Inputs/joint_matrix_int8_rowmajorA_rowmajorB_impl.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ void matrix_multiply(big_matrix<TResult, M, N> &C, big_matrix<T, M, K> &A,
7171
template <typename TResult, typename T, size_t TM, size_t TN, size_t TK>
7272
void test() {
7373
static constexpr size_t MATRIX_M = TM * 2;
74-
static constexpr size_t MATRIX_N = TN * 2;
74+
static constexpr size_t MATRIX_N = TN * 4;
7575
static constexpr size_t MATRIX_K = TK * 2;
7676
T A[MATRIX_M][MATRIX_K];
7777
T B[MATRIX_K][MATRIX_N];

sycl/test-e2e/Matrix/SG32/joint_matrix_int8_colmajorA_colmajorB.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,6 @@
1818
// This tests support of col major layout for matrix B which does transpose and
1919
// then VNNI transform. This is currently only available on AMX and PVC
2020

21-
// XFAIL: arch-intel_gpu_bmg_g21
22-
// XFAIL-TRACKER: GSD-5768
23-
2421
// UNSUPPORTED: gpu-intel-dg2
2522
// UNSUPPORTED-INTENDED: SG size = 32 is not currently supported for SYCL Joint Matrix by IGC on DG2
2623

sycl/test-e2e/Matrix/joint_matrix_bf16_fill_k_cache_unroll.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
// UNSUPPORTED: target-nvidia, target-amd
99
// UNSUPPORTED-INTENDED: aspect-ext_intel_matrix isn't currently supported for
1010
// other triples
11-
// XFAIL: run-mode
11+
// XFAIL: run-mode && (gpu-intel-dg2 || arch-intel_gpu_bmg_g21)
1212
// XFAIL-TRACKER: CMPLRLLVM-66371
1313

1414
// REQUIRES: aspect-ext_intel_matrix

sycl/test-e2e/Matrix/joint_matrix_bf16_fill_k_cache_unroll_init.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
// UNSUPPORTED-INTENDED: aspect-ext_intel_matrix isn't currently supported for
1010
// other triples
1111

12-
// XFAIL: run-mode
12+
// XFAIL: run-mode && (gpu-intel-dg2 || arch-intel_gpu_bmg_g21)
1313
// XFAIL-TRACKER: CMPLRLLVM-66371
1414

1515
// REQUIRES: aspect-ext_intel_matrix, gpu

sycl/test-e2e/Matrix/joint_matrix_int8_colmajorA_colmajorB.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
// This tests support of col major layout for matrix B which does transpose and
1818
// then VNNI transform. This is currently only available on AMX and PVC
1919

20-
// XFAIL: gpu-intel-dg2 || arch-intel_gpu_bmg_g21
20+
// XFAIL: gpu-intel-dg2
2121
// XFAIL-TRACKER: GSD-5768
2222

2323
#include "common.hpp"

0 commit comments

Comments
 (0)