Skip to content

Commit 3930847

Browse files
Address review comments
1 parent de2c4be commit 3930847

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

clang/lib/Sema/SemaSYCL.cpp

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2499,8 +2499,7 @@ class SYCLKernelNameTypeVisitor
24992499
if (const auto *TSD = dyn_cast<ClassTemplateSpecializationDecl>(RD)) {
25002500
const TemplateArgumentList &Args = TSD->getTemplateArgs();
25012501
for (unsigned I = 0; I < Args.size(); I++) {
2502-
const TemplateArgument &TemplateArg = Args[I];
2503-
Visit(TemplateArg);
2502+
Visit(Args[I]);
25042503
}
25052504
} else {
25062505
InnerTypeVisitor::Visit(T.getTypePtr());
@@ -2517,9 +2516,7 @@ class SYCLKernelNameTypeVisitor
25172516
const EnumDecl *ED = T->getDecl();
25182517
if (!ED->isScoped() && !ED->isFixed()) {
25192518
S.Diag(KernelInvocationFuncLoc, diag::err_sycl_kernel_incorrectly_named)
2520-
<< /* kernel name is invalid. Unscoped enum requires fixed underlying
2521-
type */
2522-
2;
2519+
<< /* Unscoped enum requires fixed underlying type */ 2;
25232520
S.Diag(ED->getSourceRange().getBegin(), diag::note_entity_declared_at)
25242521
<< ED;
25252522
}
@@ -2572,8 +2569,7 @@ class SYCLKernelNameTypeVisitor
25722569
for (NamedDecl *P : *TemplateParams) {
25732570
if (NonTypeTemplateParmDecl *TemplateParam =
25742571
dyn_cast<NonTypeTemplateParmDecl>(P)) {
2575-
QualType T = TemplateParam->getType();
2576-
if (const EnumType *ET = T->getAs<EnumType>()) {
2572+
if (const EnumType *ET = TemplateParam->getType()->getAs<EnumType>()) {
25772573
VisitEnumType(ET);
25782574
}
25792575
}

0 commit comments

Comments
 (0)