Skip to content

Commit 3e8f937

Browse files
authored
[SYCL][CUDA] Refactor joint_matrix tests and remove legacy cuda extension (#8951)
The new joint_matrix portable extension has been live for a while now and has made it into the latest release. In this PR I've removed the legacy Cuda only version of the extension to avoid future confusion. The Cuda joint_matrix e2e tests are also refactored so that they will pass on any tensor cores supporting gpu. Previously sm_70, sm_72, and sm_80 cases were included in the same test file. The target builtins required compilation for sm_80 or above, and despite checks for compute capability for each sm_xx test case within the main test file, since the ptx does not jit if compiled for sm_80 but ran a lower compute capability, e.g. sm_75, this led to an invalid binary error in such a case. Now the tests are split into files referencing the minimum compute capability for test cases included in the file, meaning that the test cases will run and pass on any tensor cores supporting gpu. `get_wi_data()` is deprecated in the cuda backend and we can remove this support before the next release and remove corresponding test cases from joint_matrix_apply_cuda.hpp. --------- Signed-off-by: JackAKirk <[email protected]>
1 parent c80744b commit 3e8f937

13 files changed

+394
-1977
lines changed

sycl/include/sycl/ext/oneapi/matrix/matrix-tensorcores-legacy.hpp

Lines changed: 0 additions & 778 deletions
This file was deleted.

sycl/include/sycl/ext/oneapi/matrix/matrix.hpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,6 @@
2020
#include <sycl/ext/oneapi/matrix/matrix-jit.hpp>
2121
#include <sycl/ext/oneapi/matrix/static-query.hpp>
2222
#endif // SYCL_EXT_ONEAPI_MATRIX_VERSION
23-
#if (SYCL_EXT_ONEAPI_MATRIX_VERSION == 3)
24-
#include <sycl/ext/oneapi/matrix/matrix-tensorcores-legacy.hpp>
25-
#endif // SYCL_EXT_ONEAPI_MATRIX_VERSION
2623
#if (SYCL_EXT_ONEAPI_MATRIX_VERSION == 4)
2724
#include <sycl/ext/oneapi/matrix/matrix-unified.hpp>
2825
#include <sycl/ext/oneapi/matrix/static-query-use.hpp>

sycl/test-e2e/Matrix/element_wise_all_ops_cuda.cpp

Lines changed: 0 additions & 183 deletions
This file was deleted.

sycl/test-e2e/Matrix/element_wise_all_ops_cuda_legacy.cpp

Lines changed: 0 additions & 184 deletions
This file was deleted.

0 commit comments

Comments
 (0)