Address review comments

Author: srividya-sundaram

clang/lib/Sema/SemaSYCL.cpp

@@ -986,7 +986,8 @@ static CXXMethodDecl *getOperatorParens(const CXXRecordDecl *Rec) {
 
 // Fetch the associated call operator of the kernel object
 // (of either the lambda or the function object).
-CXXMethodDecl *IsCallOperatorDefined(const CXXRecordDecl *KernelObjType) {
+CXXMethodDecl *
+GetCallOperatorOfKernelObject(const CXXRecordDecl *KernelObjType) {
   CXXMethodDecl *CallOperator = nullptr;
   if (!KernelObjType)
     return CallOperator;
@@ -2509,7 +2510,7 @@ class SyclKernelBodyCreator : public SyclKernelFieldHandler {
     // (of either the lambda or the function object).
     CXXRecordDecl *KernelObj =
         GetSYCLKernelObjectType(KernelCallerFunc)->getAsCXXRecordDecl();
-    CXXMethodDecl *WGLambdaFn = IsCallOperatorDefined(KernelObj);
+    CXXMethodDecl *WGLambdaFn = GetCallOperatorOfKernelObject(KernelObj);
 
     assert(WGLambdaFn && "non callable object is passed as kernel obj");
     // Mark the function that it "works" in a work group scope:
@@ -3467,8 +3468,7 @@ void Sema::CheckSYCLKernelCall(FunctionDecl *KernelFunc, SourceRange CallLoc,
   CXXRecordDecl *KernelObj =
       GetSYCLKernelObjectType(KernelFunc)->getAsCXXRecordDecl();
 
-  CXXMethodDecl *CallOperator = IsCallOperatorDefined(KernelObj);
-  if (!CallOperator) {
+  if (!GetCallOperatorOfKernelObject(KernelObj)) {
     Diag(Args[0]->getExprLoc(), diag::err_sycl_kernel_not_function_object);
     KernelFunc->setInvalidDecl();
     return;

clang/test/SemaSYCL/undefined-functor.cpp

@@ -8,12 +8,23 @@ queue q;
 
 struct FunctorWithoutCallOperator; // expected-note {{forward declaration of 'FunctorWithoutCallOperator'}}
 
+struct StructDefined {
+  int x;
+};
+
 int main() {
-    // expected-error@#KernelSingleTask {{kernel parameter must be a lambda or function object}}
+  
   q.submit([&](sycl::handler &cgh) {
+    // expected-error@#KernelSingleTask {{kernel parameter must be a lambda or function object}}
     // expected-error@+2 {{invalid use of incomplete type 'FunctorWithoutCallOperator'}}
     // expected-note@+1 {{in instantiation of function template specialization}}
     cgh.single_task(FunctorWithoutCallOperator{});
   });
 
+  q.submit([&](sycl::handler &cgh) {
+    // expected-error@#KernelSingleTask {{kernel parameter must be a lambda or function object}}
+    // expected-note@+1 {{in instantiation of function template specialization}}
+    cgh.single_task(StructDefined{});
+  });
+
 }