Skip to content

Commit 3fe22db

Browse files
committed
cperkins restoring default cases that return PI_INVALID_VALUE
Signed-off-by: Chris Perkins <[email protected]>
1 parent 2f7bff8 commit 3fe22db

File tree

1 file changed

+30
-0
lines changed

1 file changed

+30
-0
lines changed

sycl/plugins/level_zero/pi_level_zero.cpp

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -954,6 +954,9 @@ pi_result piPlatformGetInfo(pi_platform Platform, pi_platform_info ParamName,
954954
// information>. Follow the same notation here.
955955
//
956956
return ReturnValue(Platform->ZeDriverApiVersion.c_str());
957+
default:
958+
zePrint("piPlatformGetInfo: unrecognized ParamName\n");
959+
return PI_INVALID_VALUE;
957960
}
958961

959962
return PI_SUCCESS;
@@ -1975,6 +1978,10 @@ pi_result piQueueGetInfo(pi_queue Queue, pi_queue_info ParamName,
19751978
case PI_QUEUE_INFO_DEVICE_DEFAULT:
19761979
die("PI_QUEUE_INFO_DEVICE_DEFAULT in piQueueGetInfo not implemented\n");
19771980
break;
1981+
default:
1982+
zePrint("Unsupported ParamName in piQueueGetInfo: ParamName=%d(0x%x)\n",
1983+
ParamName, ParamName);
1984+
return PI_INVALID_VALUE;
19781985
}
19791986

19801987
return PI_SUCCESS;
@@ -3199,6 +3206,10 @@ pi_result piKernelGetInfo(pi_kernel Kernel, pi_kernel_info ParamName,
31993206
} catch (...) {
32003207
return PI_ERROR_UNKNOWN;
32013208
}
3209+
default:
3210+
zePrint("Unsupported ParamName in piKernelGetInfo: ParamName=%d(0x%x)\n",
3211+
ParamName, ParamName);
3212+
return PI_INVALID_VALUE;
32023213
}
32033214

32043215
return PI_SUCCESS;
@@ -3253,6 +3264,10 @@ pi_result piKernelGetGroupInfo(pi_kernel Kernel, pi_device Device,
32533264
}
32543265
case PI_KERNEL_GROUP_INFO_PRIVATE_MEM_SIZE:
32553266
return ReturnValue(pi_uint32{ZeKernelProperties.privateMemSize});
3267+
default:
3268+
zePrint("Unknown ParamName in piKernelGetGroupInfo: ParamName=%d(0x%x)\n",
3269+
ParamName, ParamName);
3270+
return PI_INVALID_VALUE;
32563271
}
32573272
return PI_SUCCESS;
32583273
}
@@ -3517,6 +3532,10 @@ pi_result piEventGetInfo(pi_event Event, pi_event_info ParamName,
35173532
}
35183533
case PI_EVENT_INFO_REFERENCE_COUNT:
35193534
return ReturnValue(pi_uint32{Event->RefCount});
3535+
default:
3536+
zePrint("Unsupported ParamName in piEventGetInfo: ParamName=%d(%x)\n",
3537+
ParamName, ParamName);
3538+
return PI_INVALID_VALUE;
35203539
}
35213540

35223541
return PI_SUCCESS;
@@ -3569,6 +3588,9 @@ pi_result piEventGetProfilingInfo(pi_event Event, pi_profiling_info ParamName,
35693588
case PI_PROFILING_INFO_COMMAND_SUBMIT:
35703589
// TODO: Support these when Level Zero supported is added.
35713590
return ReturnValue(uint64_t{0});
3591+
default:
3592+
zePrint("piEventGetProfilingInfo: not supported ParamName\n");
3593+
return PI_INVALID_VALUE;
35723594
}
35733595

35743596
return PI_SUCCESS;
@@ -3785,6 +3807,11 @@ pi_result piSamplerCreate(pi_context Context,
37853807
case PI_SAMPLER_ADDRESSING_MODE_MIRRORED_REPEAT:
37863808
ZeSamplerDesc.addressMode = ZE_SAMPLER_ADDRESS_MODE_MIRROR;
37873809
break;
3810+
default:
3811+
zePrint("piSamplerCreate: unsupported PI_SAMPLER_ADDRESSING_MODE "
3812+
"value\n");
3813+
zePrint("PI_SAMPLER_ADDRESSING_MODE=%d\n", CurValueAddressingMode);
3814+
return PI_INVALID_VALUE;
37883815
}
37893816
} break;
37903817

@@ -5328,6 +5355,9 @@ pi_result piextUSMGetMemAllocInfo(pi_context Context, const void *Ptr,
53285355
ZE_CALL(zeMemGetAddressRange(Context->ZeContext, Ptr, nullptr, &Size));
53295356
return ReturnValue(Size);
53305357
}
5358+
default:
5359+
zePrint("piextUSMGetMemAllocInfo: unsupported ParamName\n");
5360+
return PI_INVALID_VALUE;
53315361
}
53325362
return PI_SUCCESS;
53335363
}

0 commit comments

Comments
 (0)