Skip to content

Commit 4212237

Browse files
author
Artem Gindinson
authored
[SYCL] Improve code-ownership rules for ESIMD/Tools (#5287)
The patch aims to enforce ESIMD-specific code-ownership on the newly created dedicated directories. This allows for seamless DPC++ Tools code-ownership of non-ESIMD `llvm/`-contained files. Signed-off-by: Artem Gindinson <[email protected]>
1 parent 106882c commit 4212237

27 files changed

+17
-17
lines changed

.github/CODEOWNERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ llvm/ @intel/dpcpp-tools-reviewers
4848
clang/tools/clang-offload-*/ @intel/dpcpp-tools-reviewers
4949

5050
# Explicit SIMD
51-
SYCLLowerIR/ @intel/dpcpp-esimd-reviewers
51+
ESIMD/ @intel/dpcpp-esimd-reviewers
5252
esimd/ @intel/dpcpp-esimd-reviewers
5353
sycl/include/sycl/ext/intel/experimental/esimd.hpp @intel/dpcpp-esimd-reviewers
5454
sycl/doc/extensions/ExplicitSIMD/ @intel/dpcpp-esimd-reviewers

clang/lib/CodeGen/BackendUtil.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
#include "llvm/Passes/PassBuilder.h"
4343
#include "llvm/Passes/PassPlugin.h"
4444
#include "llvm/Passes/StandardInstrumentations.h"
45-
#include "llvm/SYCLLowerIR/ESIMDVerifier.h"
45+
#include "llvm/SYCLLowerIR/ESIMD/ESIMDVerifier.h"
4646
#include "llvm/SYCLLowerIR/LowerWGLocalMemory.h"
4747
#include "llvm/SYCLLowerIR/MutatePrintfAddrspace.h"
4848
#include "llvm/Support/BuryPointer.h"

llvm/include/llvm/LinkAllPasses.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
#include "llvm/CodeGen/Passes.h"
3838
#include "llvm/IR/Function.h"
3939
#include "llvm/IR/IRPrintingPasses.h"
40-
#include "llvm/SYCLLowerIR/ESIMDVerifier.h"
40+
#include "llvm/SYCLLowerIR/ESIMD/ESIMDVerifier.h"
4141
#include "llvm/SYCLLowerIR/MutatePrintfAddrspace.h"
4242
#include "llvm/Support/Valgrind.h"
4343
#include "llvm/Transforms/AggressiveInstCombine/AggressiveInstCombine.h"

llvm/lib/Passes/PassBuilder.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,8 @@
7676
#include "llvm/IR/PrintPasses.h"
7777
#include "llvm/IR/SafepointIRVerifier.h"
7878
#include "llvm/IR/Verifier.h"
79-
#include "llvm/SYCLLowerIR/ESIMDVerifier.h"
80-
#include "llvm/SYCLLowerIR/LowerESIMD.h"
79+
#include "llvm/SYCLLowerIR/ESIMD/ESIMDVerifier.h"
80+
#include "llvm/SYCLLowerIR/ESIMD/LowerESIMD.h"
8181
#include "llvm/SYCLLowerIR/LowerWGScope.h"
8282
#include "llvm/SYCLLowerIR/MutatePrintfAddrspace.h"
8383
#include "llvm/Support/CommandLine.h"

llvm/lib/SYCLLowerIR/CMakeLists.txt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,12 @@ set_property(GLOBAL PROPERTY LLVMGenXIntrinsics_SOURCE_PROP ${LLVMGenXIntrinsics
4848
set_property(GLOBAL PROPERTY LLVMGenXIntrinsics_BINARY_PROP ${LLVMGenXIntrinsics_BINARY_DIR})
4949

5050
add_llvm_component_library(LLVMSYCLLowerIR
51+
ESIMD/LowerESIMD.cpp
52+
ESIMD/LowerESIMDVLoadVStore.cpp
53+
ESIMD/LowerESIMDVecArg.cpp
54+
ESIMD/ESIMDVerifier.cpp
5155
LowerWGScope.cpp
52-
LowerESIMD.cpp
53-
LowerESIMDVLoadVStore.cpp
54-
LowerESIMDVecArg.cpp
5556
LowerWGLocalMemory.cpp
56-
ESIMDVerifier.cpp
5757
MutatePrintfAddrspace.cpp
5858

5959
ADDITIONAL_HEADER_DIRS

llvm/lib/SYCLLowerIR/ESIMDVerifier.cpp renamed to llvm/lib/SYCLLowerIR/ESIMD/ESIMDVerifier.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
//
1212
//===----------------------------------------------------------------------===//
1313

14-
#include "llvm/SYCLLowerIR/ESIMDVerifier.h"
14+
#include "llvm/SYCLLowerIR/ESIMD/ESIMDVerifier.h"
1515
#include "llvm/Demangle/Demangle.h"
1616
#include "llvm/IR/InstIterator.h"
1717
#include "llvm/IR/Instructions.h"

llvm/lib/SYCLLowerIR/LowerESIMD.cpp renamed to llvm/lib/SYCLLowerIR/ESIMD/LowerESIMD.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
// values of integer template parameters they were instantiated with.
1414
//===----------------------------------------------------------------------===//
1515

16-
#include "llvm/SYCLLowerIR/LowerESIMD.h"
16+
#include "llvm/SYCLLowerIR/ESIMD/LowerESIMD.h"
1717

1818
#include "llvm/ADT/DenseMap.h"
1919
#include "llvm/ADT/DenseSet.h"
@@ -126,8 +126,8 @@ struct ESIMDIntrinDesc {
126126
// -1 denotes return value
127127
GenXArgConversion Conv; // GenXArgConversion
128128
} Arg;
129-
int NRemArgs; // SRC_CALL_ALL: number of remaining args
130-
unsigned int ArgConst; // CONST_I16 OR CONST_I32: constant value
129+
int NRemArgs; // SRC_CALL_ALL: number of remaining args
130+
unsigned int ArgConst; // CONST_I16 OR CONST_I32: constant value
131131
} I;
132132
};
133133

@@ -546,7 +546,7 @@ class SimpleAllocator {
546546
Ptrs.resize(0);
547547
}
548548

549-
template <typename T, typename... Args> T *makeNode(Args &&... args) {
549+
template <typename T, typename... Args> T *makeNode(Args &&...args) {
550550
void *Ptr = std::calloc(1, sizeof(T));
551551
Ptrs.push_back(Ptr);
552552
return new (Ptr) T(std::forward<Args>(args)...);

llvm/lib/SYCLLowerIR/LowerESIMDVLoadVStore.cpp renamed to llvm/lib/SYCLLowerIR/ESIMD/LowerESIMDVLoadVStore.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
#include "llvm/IR/Instructions.h"
2929
#include "llvm/IR/IntrinsicInst.h"
3030
#include "llvm/IR/Module.h"
31-
#include "llvm/SYCLLowerIR/LowerESIMD.h"
31+
#include "llvm/SYCLLowerIR/ESIMD/LowerESIMD.h"
3232
#include "llvm/Support/Debug.h"
3333
#include "llvm/Transforms/Scalar.h"
3434

llvm/lib/SYCLLowerIR/LowerESIMDVecArg.cpp renamed to llvm/lib/SYCLLowerIR/ESIMD/LowerESIMDVecArg.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@
6767
// i64 0, i32 0))
6868
//===----------------------------------------------------------------------===//
6969

70-
#include "llvm/SYCLLowerIR/LowerESIMD.h"
70+
#include "llvm/SYCLLowerIR/ESIMD/LowerESIMD.h"
7171

7272
#include "llvm/Transforms/Utils/BasicBlockUtils.h"
7373
#include "llvm/Transforms/Utils/Cloning.h"

llvm/tools/sycl-post-link/sycl-post-link.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
#include "llvm/IR/LegacyPassManager.h"
2828
#include "llvm/IR/Module.h"
2929
#include "llvm/IRReader/IRReader.h"
30-
#include "llvm/SYCLLowerIR/LowerESIMD.h"
30+
#include "llvm/SYCLLowerIR/ESIMD/LowerESIMD.h"
3131
#include "llvm/Support/CommandLine.h"
3232
#include "llvm/Support/FileSystem.h"
3333
#include "llvm/Support/InitLLVM.h"

0 commit comments

Comments
 (0)