Skip to content

Commit 435013a

Browse files
EwanCBensuoaarongreig
committed
FIx comment typos
Co-authored-by: Ben Tracy <[email protected]> Co-authored-by: aarongreig <[email protected]>
1 parent d1c6833 commit 435013a

File tree

3 files changed

+8
-7
lines changed

3 files changed

+8
-7
lines changed

source/adapters/cuda/kernel.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ struct ur_kernel_handle_t_ {
167167
AlignedLocalSize);
168168

169169
// For every existing local argument which follows at later argument
170-
// indices, updated the offset and pointer into the kernel local memory.
170+
// indices, update the offset and pointer into the kernel local memory.
171171
// Required as padding will need to be recalculated.
172172
const size_t NumArgs = Indices.size() - 1; // Accounts for implicit arg
173173
for (auto SuccIndex = Index + 1; SuccIndex < NumArgs; SuccIndex++) {

source/adapters/hip/kernel.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ struct ur_kernel_handle_t_ {
162162
AlignedLocalSize);
163163

164164
// For every existing local argument which follows at later argument
165-
// indices, updated the offset and pointer into the kernel local memory.
165+
// indices, update the offset and pointer into the kernel local memory.
166166
// Required as padding will need to be recalculated.
167167
const size_t NumArgs = Indices.size() - 1; // Accounts for implicit arg
168168
for (auto SuccIndex = Index + 1; SuccIndex < NumArgs; SuccIndex++) {

test/conformance/exp_command_buffer/update/local_memory_update.cpp

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@ struct LocalMemoryUpdateTestBase
2121
<< "Local memory argument update not supported on Level Zero.";
2222
}
2323

24-
// HIP has extra args for local memory so we define an offset for arg indices here for updating
24+
// HIP has extra args for local memory so we define an offset for arg
25+
// indices here for updating
2526
hip_arg_offset = backend == UR_PLATFORM_BACKEND_HIP ? 3 : 0;
2627
ur_device_usm_access_capability_flags_t shared_usm_flags;
2728
ASSERT_SUCCESS(
@@ -313,7 +314,7 @@ TEST_P(LocalMemoryUpdateTest, UpdateLocalOnly) {
313314
// Test updating A,X,Y parameters to new values and omitting local memory parameters
314315
// from the update.
315316
TEST_P(LocalMemoryUpdateTest, UpdateParametersEmptyLocalSize) {
316-
// Run command-buffer prior to update an verify output
317+
// Run command-buffer prior to update and verify output
317318
ASSERT_SUCCESS(urCommandBufferEnqueueExp(updatable_cmd_buf_handle, queue, 0,
318319
nullptr, nullptr));
319320
ASSERT_SUCCESS(urQueueFinish(queue));
@@ -547,7 +548,7 @@ TEST_P(LocalMemoryUpdateTest, UpdateParametersSmallerLocalSize) {
547548
// Test updating A,X,Y parameters to new values and local memory parameters
548549
// to new larger values.
549550
TEST_P(LocalMemoryUpdateTest, UpdateParametersLargerLocalSize) {
550-
// Run command-buffer prior to update an verify output
551+
// Run command-buffer prior to update and verify output
551552
ASSERT_SUCCESS(urCommandBufferEnqueueExp(updatable_cmd_buf_handle, queue, 0,
552553
nullptr, nullptr));
553554
ASSERT_SUCCESS(urQueueFinish(queue));
@@ -700,10 +701,10 @@ TEST_P(LocalMemoryUpdateTest, UpdateParametersLargerLocalSize) {
700701
}
701702

702703
// Test updating A,X,Y parameters to new values and only one of the local memory
703-
// parameters, which is set to a new values. Then a separate update call for
704+
// parameters, which is set to a new value. Then a separate update call for
704705
// the other local memory argument.
705706
TEST_P(LocalMemoryUpdateTest, UpdateParametersPartialLocalSize) {
706-
// Run command-buffer prior to update an verify output
707+
// Run command-buffer prior to update and verify output
707708
ASSERT_SUCCESS(urCommandBufferEnqueueExp(updatable_cmd_buf_handle, queue, 0,
708709
nullptr, nullptr));
709710
ASSERT_SUCCESS(urQueueFinish(queue));

0 commit comments

Comments
 (0)