Skip to content

Commit 444afde

Browse files
authored
[LinkerWrapper][NFC] Fix extra copy issue (#11636)
This PR fixes an issue that causes extra copy. Signed-off-by: Arvind Sudarsanam <[email protected]>
1 parent ff64511 commit 444afde

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -529,7 +529,7 @@ struct Table {
529529

530530
SmallVector<std::string, 16> getListOfIRFiles(void) {
531531
SmallVector<std::string, 16> Files;
532-
for (auto Entry : Entries) {
532+
for (auto &Entry : Entries) {
533533
Files.push_back(Entry.IRFile);
534534
}
535535
return Files;
@@ -546,7 +546,7 @@ struct Table {
546546
if (EC)
547547
reportError(errorCodeToError(EC));
548548
TableFile << "[Code|Properties|Symbols]\n";
549-
for (auto Entry : Entries) {
549+
for (auto &Entry : Entries) {
550550
TableFile << Entry.IRFile << "|";
551551
TableFile << Entry.PropFile << "|";
552552
TableFile << Entry.SymFile << "\n";
@@ -742,7 +742,7 @@ Expected<StringRef> linkDeviceInputFiles(SmallVectorImpl<StringRef> &InputFiles,
742742

743743
SmallVector<StringRef, 8> CmdArgs;
744744
CmdArgs.push_back(*LLVMLinkPath);
745-
for (auto File : InputFiles)
745+
for (auto &File : InputFiles)
746746
CmdArgs.push_back(File);
747747
CmdArgs.push_back("-o");
748748
CmdArgs.push_back(*OutFileOrErr);
@@ -979,7 +979,7 @@ void diagnosticHandler(const DiagnosticInfo &DI) {
979979
std::vector<std::string> getTargetFeatures(ArrayRef<OffloadFile> InputFiles) {
980980
SmallVector<StringRef> Features;
981981
for (const OffloadFile &File : InputFiles) {
982-
for (auto Arg : llvm::split(File.getBinary()->getString("feature"), ","))
982+
for (auto &Arg : llvm::split(File.getBinary()->getString("feature"), ","))
983983
Features.emplace_back(Arg);
984984
}
985985

0 commit comments

Comments
 (0)