Skip to content

Commit 44f120e

Browse files
authored
[UR] Remove unnecessary unique pointer from cl program helper. (#17101)
1 parent 19dbfb7 commit 44f120e

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

unified-runtime/source/adapters/opencl/program.cpp

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@
1414
#include "device.hpp"
1515
#include "platform.hpp"
1616

17-
static ur_result_t getDevicesFromProgram(
18-
ur_program_handle_t hProgram,
19-
std::unique_ptr<std::vector<cl_device_id>> &DevicesInProgram) {
17+
static ur_result_t
18+
getDevicesFromProgram(ur_program_handle_t hProgram,
19+
std::vector<cl_device_id> &DevicesInProgram) {
2020

2121
cl_uint DeviceCount;
2222
CL_RETURN_ON_FAILURE(clGetProgramInfo(cl_adapter::cast<cl_program>(hProgram),
@@ -27,11 +27,11 @@ static ur_result_t getDevicesFromProgram(
2727
return UR_RESULT_ERROR_INVALID_CONTEXT;
2828
}
2929

30-
DevicesInProgram = std::make_unique<std::vector<cl_device_id>>(DeviceCount);
30+
DevicesInProgram.resize(DeviceCount);
3131

3232
CL_RETURN_ON_FAILURE(clGetProgramInfo(
3333
cl_adapter::cast<cl_program>(hProgram), CL_PROGRAM_DEVICES,
34-
DeviceCount * sizeof(cl_device_id), (*DevicesInProgram).data(), nullptr));
34+
DeviceCount * sizeof(cl_device_id), DevicesInProgram.data(), nullptr));
3535

3636
return UR_RESULT_SUCCESS;
3737
}
@@ -157,12 +157,12 @@ UR_APIEXPORT ur_result_t UR_APICALL
157157
urProgramCompile([[maybe_unused]] ur_context_handle_t hContext,
158158
ur_program_handle_t hProgram, const char *pOptions) {
159159

160-
std::unique_ptr<std::vector<cl_device_id>> DevicesInProgram;
160+
std::vector<cl_device_id> DevicesInProgram;
161161
UR_RETURN_ON_FAILURE(getDevicesFromProgram(hProgram, DevicesInProgram));
162162

163163
CL_RETURN_ON_FAILURE(clCompileProgram(cl_adapter::cast<cl_program>(hProgram),
164-
DevicesInProgram->size(),
165-
DevicesInProgram->data(), pOptions, 0,
164+
DevicesInProgram.size(),
165+
DevicesInProgram.data(), pOptions, 0,
166166
nullptr, nullptr, nullptr, nullptr));
167167

168168
return UR_RESULT_SUCCESS;
@@ -215,12 +215,12 @@ UR_APIEXPORT ur_result_t UR_APICALL
215215
urProgramBuild([[maybe_unused]] ur_context_handle_t hContext,
216216
ur_program_handle_t hProgram, const char *pOptions) {
217217

218-
std::unique_ptr<std::vector<cl_device_id>> DevicesInProgram;
218+
std::vector<cl_device_id> DevicesInProgram;
219219
UR_RETURN_ON_FAILURE(getDevicesFromProgram(hProgram, DevicesInProgram));
220220

221221
CL_RETURN_ON_FAILURE(clBuildProgram(
222-
cl_adapter::cast<cl_program>(hProgram), DevicesInProgram->size(),
223-
DevicesInProgram->data(), pOptions, nullptr, nullptr));
222+
cl_adapter::cast<cl_program>(hProgram), DevicesInProgram.size(),
223+
DevicesInProgram.data(), pOptions, nullptr, nullptr));
224224
return UR_RESULT_SUCCESS;
225225
}
226226

0 commit comments

Comments
 (0)