Skip to content

Commit 455e9bf

Browse files
authored
[SYCL][E2E] Change UNSUPPORTED to XFAIL in two SubGroup tests (#15780)
The failures related to these two tests were masked due to using unsupported rather than xfail. This patch also removes the check for OpenCL version before querying `sub_group_independent_forward_progress`, as it masks the failure on the fpga emulator device.
1 parent 0c7e1cb commit 455e9bf

File tree

2 files changed

+10
-25
lines changed

2 files changed

+10
-25
lines changed

sycl/test-e2e/SubGroup/attributes.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
// UNSUPPORTED: accelerator
2-
// TODO: FPGAs currently report supported subgroups as {4,8,16,32,64}, causing
3-
// this test to fail
4-
// UNSUPPORTED: cuda || hip
5-
// TODO: Device subgroup sizes reports {32}, but when we try to use it with a
6-
// kernel attribute and check it, we get a subgroup size of 0.
1+
// TODO: Despite using a supported required subgroup size compile_sub_group_size
2+
// reports as 0 on fpga emu, cuda and hip
3+
// XFAIL: accelerator
4+
// XFAIL-TRACKER: URT-697
5+
// XFAIL: cuda || hip
6+
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/14357
77

88
// RUN: %{build} -fsycl-device-code-split=per_kernel -o %t.out
99
// RUN: %{run} %t.out

sycl/test-e2e/SubGroup/info.cpp

Lines changed: 4 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
1-
// UNSUPPORTED: accelerator
2-
// TODO: FPGAs currently report supported subgroups as {4,8,16,32,64}, causing
3-
// this test to fail. Additionally, the kernel max_sub_group_size checks
4-
// crash on FPGAs
1+
// TODO: fpga emu crashes when querying sub_group_independent_forward_progress
2+
// XFAIL: accelerator
3+
// XFAIL-TRACKER: URT-697
54
// RUN: %{build} -o %t.out
65
// RUN: %{run} %t.out
76

@@ -20,21 +19,7 @@ using namespace sycl;
2019
int main() {
2120
queue Queue;
2221
device Device = Queue.get_device();
23-
24-
bool old_opencl = false;
25-
if (Device.get_backend() == sycl::backend::opencl) {
26-
// Extract the numerical version from the version string, OpenCL version
27-
// string have the format "OpenCL <major>.<minor> <vendor specific data>".
28-
std::string ver = Device.get_info<info::device::version>().substr(7, 3);
29-
old_opencl = (ver < "2.1");
30-
}
31-
32-
/* Check info::device parameters. */
33-
if (!old_opencl) {
34-
// Independent forward progress is missing on OpenCL backend prior to
35-
// version 2.1
36-
Device.get_info<info::device::sub_group_independent_forward_progress>();
37-
}
22+
Device.get_info<info::device::sub_group_independent_forward_progress>();
3823
Device.get_info<info::device::max_num_sub_groups>();
3924

4025
try {

0 commit comments

Comments
 (0)