Skip to content

Commit 47d5c43

Browse files
authored
Merge pull request #2654 from pbalcer/add-sycl-target-pvc
[benchmarks] don't fail on suite setup issues
2 parents d83e83a + e0f6e18 commit 47d5c43

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

scripts/benchmarks/benches/oneapi.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,12 @@ def install_package(self, name, url):
2929

3030
package = download(self.oneapi_dir, url, f'package_{name}.sh')
3131
try:
32-
print(f"installing f{name}")
32+
print(f"installing {name}")
3333
run(f"sh {package} -a -s --eula accept --install-dir {self.oneapi_dir} --instance f{self.ONEAPI_BENCHMARK_INSTANCE_ID}")
3434
except:
3535
print("oneAPI installation likely exists already")
3636
return
37-
print(f"f{name} installation complete")
37+
print(f"{name} installation complete")
3838

3939
def package_dir(self, package, dir):
4040
return os.path.join(self.oneapi_dir, package, 'latest', dir)

scripts/benchmarks/main.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -143,9 +143,13 @@ def main(directory, additional_env_vars, save_name, compare_names, filter):
143143

144144
if suite_benchmarks:
145145
print(f"Setting up {type(s).__name__}")
146-
s.setup()
147-
print(f"{type(s).__name__} setup complete.")
148-
benchmarks += suite_benchmarks
146+
try:
147+
s.setup()
148+
except:
149+
print(f"{type(s).__name__} setup failed. Benchmarks won't be added.")
150+
else:
151+
print(f"{type(s).__name__} setup complete.")
152+
benchmarks += suite_benchmarks
149153

150154
for b in benchmarks:
151155
print(b.name())

0 commit comments

Comments
 (0)