[SYCL] Fix weak_object move and copy assignment (#8716)

This commit fixes an issue where the copy and move assignment operators
of the weak_object class would be implicitly deleted due to them being
missing from the base class.

Signed-off-by: Larsen, Steffen <[email protected]>

Author: steffenlarsen

sycl/include/sycl/ext/oneapi/weak_object_base.hpp

@@ -33,6 +33,9 @@ template <typename SYCLObjT> class weak_object_base {
   weak_object_base(const weak_object_base &Other) noexcept = default;
   weak_object_base(weak_object_base &&Other) noexcept = default;
 
+  weak_object_base &operator=(const weak_object_base &Other) noexcept = default;
+  weak_object_base &operator=(weak_object_base &&Other) noexcept = default;
+
   void reset() noexcept { MObjWeakPtr.reset(); }
   void swap(weak_object_base &Other) noexcept {
     MObjWeakPtr.swap(Other.MObjWeakPtr);

sycl/unittests/Extensions/WeakObject.cpp

@@ -198,6 +198,39 @@ template <typename SyclObjT> struct WeakObjectCheckOwnerLessMap {
   }
 };
 
+template <typename SyclObjT> struct WeakObjectCheckCopy {
+  void operator()(SyclObjT Obj) {
+    sycl::ext::oneapi::weak_object<SyclObjT> WeakObj{Obj};
+
+    sycl::ext::oneapi::weak_object<SyclObjT> WeakObjCopyCtor{WeakObj};
+    sycl::ext::oneapi::weak_object<SyclObjT> WeakObjCopyAssign = WeakObj;
+
+    EXPECT_FALSE(WeakObjCopyCtor.expired());
+    EXPECT_FALSE(WeakObjCopyAssign.expired());
+
+    EXPECT_TRUE(WeakObjCopyCtor.lock() == Obj);
+    EXPECT_TRUE(WeakObjCopyAssign.lock() == Obj);
+  }
+};
+
+template <typename SyclObjT> struct WeakObjectCheckMove {
+  void operator()(SyclObjT Obj) {
+    sycl::ext::oneapi::weak_object<SyclObjT> WeakObj1{Obj};
+    sycl::ext::oneapi::weak_object<SyclObjT> WeakObj2{Obj};
+
+    sycl::ext::oneapi::weak_object<SyclObjT> WeakObjMoveCtor{
+        std::move(WeakObj1)};
+    sycl::ext::oneapi::weak_object<SyclObjT> WeakObjMoveAssign =
+        std::move(WeakObj2);
+
+    EXPECT_FALSE(WeakObjMoveCtor.expired());
+    EXPECT_FALSE(WeakObjMoveAssign.expired());
+
+    EXPECT_TRUE(WeakObjMoveCtor.lock() == Obj);
+    EXPECT_TRUE(WeakObjMoveAssign.lock() == Obj);
+  }
+};
+
 template <template <typename> typename CallableT>
 void runTest(sycl::unittest::PiMock &Mock) {
   sycl::platform Plt = Mock.getPlatform();
@@ -385,3 +418,13 @@ TEST(WeakObjectTest, WeakObjectOwnerLessMap) {
   sycl::unittest::PiMock Mock;
   runTestMulti<WeakObjectCheckOwnerLessMap>(Mock);
 }
+
+TEST(WeakObjectTest, WeakObjectCopy) {
+  sycl::unittest::PiMock Mock;
+  runTest<WeakObjectCheckCopy>(Mock);
+}
+
+TEST(WeakObjectTest, WeakObjectMove) {
+  sycl::unittest::PiMock Mock;
+  runTest<WeakObjectCheckMove>(Mock);
+}